From: Junio C Hamano <gitster@pobox.com>
To: Toon Claes <toon@iotcl.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 1/1] Documentation: correct hash environment variable
Date: Wed, 27 May 2020 10:05:03 -0700 [thread overview]
Message-ID: <xmqq1rn5mhq8.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200526183720.120314-2-toon@iotcl.com> (Toon Claes's message of "Tue, 26 May 2020 20:37:20 +0200")
Toon Claes <toon@iotcl.com> writes:
> To set the default hash algorithm you can set the `GIT_DEFAULT_HASH`
> environment variable. In the documentation this variable is named
> `GIT_DEFAULT_HASH_ALGORITHM`, which is incorrect.
My reading stuttered while reading words around "to set ... you can
set"; I would have written
The GIT_DEFAULT_HASH environment variable, which is the way
to specify the default hash algorithm, was misspelled in the
documentation. Fix it.
but it's OK.
As you said, bc/sha-256-part-1-of-4 is new in this release, so let's
merge this fix down before the final.
Thanks.
> Signed-off-by: Toon Claes <toon@iotcl.com>
> ---
> Documentation/git.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/git.txt b/Documentation/git.txt
> index 9d6769e95a..12890841c4 100644
> --- a/Documentation/git.txt
> +++ b/Documentation/git.txt
> @@ -493,7 +493,7 @@ double-quotes and respecting backslash escapes. E.g., the value
> details. This variable has lower precedence than other path
> variables such as GIT_INDEX_FILE, GIT_OBJECT_DIRECTORY...
>
> -`GIT_DEFAULT_HASH_ALGORITHM`::
> +`GIT_DEFAULT_HASH`::
> If this variable is set, the default hash algorithm for new
> repositories will be set to this value. This value is currently
> ignored when cloning; the setting of the remote repository
prev parent reply other threads:[~2020-05-27 17:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 18:37 [PATCH v2 0/1] Documentation fix related to hash algorithm Toon Claes
2020-05-26 18:37 ` [PATCH v2 1/1] Documentation: correct hash environment variable Toon Claes
2020-05-27 17:05 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1rn5mhq8.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=toon@iotcl.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).