From: Junio C Hamano <gitster@pobox.com>
To: "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Derrick Stolee <dstolee@microsoft.com>
Subject: Re: [PATCH] fsck: use ERROR_MULTI_PACK_INDEX
Date: Tue, 19 May 2020 16:12:59 -0700 [thread overview]
Message-ID: <xmqq1rnfzfgk.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <pull.637.git.1589917725263.gitgitgadget@gmail.com> (Derrick Stolee via GitGitGadget's message of "Tue, 19 May 2020 19:48:45 +0000")
"Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Derrick Stolee <dstolee@microsoft.com>
>
> The multi-pack-index was added to the data verified by git-fsck in
> ea5ae6c3 "fsck: verify multi-pack-index".
That's 66ec0390 (fsck: verify multi-pack-index, 2018-09-13) that
first appeared in v2.20
> This implementation was
> based on the implementation for verifying the commit-graph, and a
> copy-paste error kept the ERROR_COMMIT_GRAPH flag as the bit set
> when an error appears in the multi-pack-index.
>
> Add a new flag, ERROR_MULTI_PACK_INDEX, and use that instead.
Thanks. Will queue.
prev parent reply other threads:[~2020-05-19 23:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 19:48 [PATCH] fsck: use ERROR_MULTI_PACK_INDEX Derrick Stolee via GitGitGadget
2020-05-19 23:12 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1rnfzfgk.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).