From: Junio C Hamano <gitster@pobox.com>
To: Beat Bolli <dev+git@drbeat.li>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] grep: print the pcre2_jit_on value
Date: Tue, 23 Jul 2019 10:34:57 -0700 [thread overview]
Message-ID: <xmqq1rygu01q.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190722181923.21572-1-dev+git@drbeat.li> (Beat Bolli's message of "Mon, 22 Jul 2019 20:19:23 +0200")
Beat Bolli <dev+git@drbeat.li> writes:
> When pcre2_jit_on is neither 1 nor 0, the BUG() call printed the value
> of pcre1_jit_on.
>
> Print the value of pcre2_jit_on instead.
>
> Signed-off-by: Beat Bolli <dev+git@drbeat.li>
> ---
Thanks.
> grep.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/grep.c b/grep.c
> index f7c3a5803e..cd952ef5d3 100644
> --- a/grep.c
> +++ b/grep.c
> @@ -559,7 +559,7 @@ static void compile_pcre2_pattern(struct grep_pat *p, const struct grep_opt *opt
> pcre2_jit_stack_assign(p->pcre2_match_context, NULL, p->pcre2_jit_stack);
> } else if (p->pcre2_jit_on != 0) {
> BUG("The pcre2_jit_on variable should be 0 or 1, not %d",
> - p->pcre1_jit_on);
> + p->pcre2_jit_on);
> }
> }
next prev parent reply other threads:[~2019-07-23 17:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 18:19 [PATCH] grep: print the pcre2_jit_on value Beat Bolli
2019-07-23 17:34 ` Junio C Hamano [this message]
2019-07-23 19:19 ` Johannes Schindelin
2019-07-24 21:25 ` Beat Bolli
2019-07-25 9:13 ` Johannes Schindelin
2019-07-29 8:43 ` Carlo Arenas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1rygu01q.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=dev+git@drbeat.li \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox