From: Junio C Hamano <gitster@pobox.com>
To: "Martin Ågren" <martin.agren@gmail.com>
Cc: Duy Nguyen <pclouds@gmail.com>, Jeff King <peff@peff.net>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 4/5] lock_file: make function-local locks non-static
Date: Thu, 10 May 2018 13:26:24 +0900 [thread overview]
Message-ID: <xmqq1sekkufj.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CAN0heSr7mdaMRxsy-Aev3RpBf-9Xvg6Gw_=UyRqV0FPCVx0KNQ@mail.gmail.com> ("Martin Ågren"'s message of "Wed, 9 May 2018 19:07:36 +0200")
Martin Ågren <martin.agren@gmail.com> writes:
> On 9 May 2018 at 18:19, Duy Nguyen <pclouds@gmail.com> wrote:
>> On Tue, May 8, 2018 at 8:18 PM, Jeff King <peff@peff.net> wrote:
>
>>> It should be totally safe. If you look at "struct lock_file", it is now
>>> simply a pointer to a tempfile allocated on the heap (in fact, I thought
>>> about getting rid of lock_file entirely, but the diff is noisy and it
>>> actually has some value as an abstraction over a pure tempfile).
>>
>> Ah.. I did miss that "everything on heap" thing. Sorry for the noise
>> Martin and thanks for clarification Jeff :)
>
> Hey, no problem. In fact, the "noise" as you call it had some signal in
> it: the commit messages should obviously say more about this.
Thanks all for working it out.
prev parent reply other threads:[~2018-05-10 4:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-06 14:10 [PATCH 4/5] lock_file: make function-local locks non-static Martin Ågren
2018-05-06 17:26 ` Duy Nguyen
2018-05-06 17:42 ` Duy Nguyen
2018-05-06 19:32 ` Martin Ågren
2018-05-07 15:24 ` Duy Nguyen
2018-05-07 21:19 ` Martin Ågren
2018-05-08 18:18 ` Jeff King
2018-05-09 16:19 ` Duy Nguyen
2018-05-09 17:07 ` Martin Ågren
2018-05-10 4:26 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1sekkufj.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=martin.agren@gmail.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).