Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	git@vger.kernel.org, Jeff Hostetler <jeffhost@microsoft.com>
Subject: Re: [PATCH] mingw: make stderr unbuffered again
Date: Thu, 16 Feb 2017 10:01:44 -0800	[thread overview]
Message-ID: <xmqq1suyypyv.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <d1c65a34-3809-ee76-5e00-69ba715e0093@kdbg.org> (Johannes Sixt's message of "Thu, 16 Feb 2017 18:55:41 +0100")

Johannes Sixt <j6t@kdbg.org> writes:

> Am 16.02.2017 um 18:10 schrieb Johannes Schindelin:
>> On Wed, 15 Feb 2017, Johannes Sixt wrote:
>>> I do not see how dup2() causes a change in stdio state. I
>>> must be missing something (and that may be a basic misunderstanding of how
>>> stdio is initialized).
>>
>> It appears that dup2()ing fd 2 resets that stdio state.
>
> OK, thanks. It's surprising, but so be it.
>
> Thank you for the quick fix!

I am happy to see two Windows folks being happy.  I tentatively
marked this as "undecided" after merging it to 'next', but let's
have it in the -rc2 and final.  Two people familiar with Windows
agreeing that there is no longer mystery why it fixes, after seeing
that the update fixes a regression, is a strong enough sign to me
that including it is better than leaving it out.

Thanks.

  reply	other threads:[~2017-02-16 18:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-13 22:34 [PATCH] mingw: make stderr unbuffered again Johannes Schindelin
2017-02-13 22:39 ` Junio C Hamano
2017-02-14 14:47   ` Johannes Schindelin
2017-02-14 18:45     ` Johannes Sixt
2017-02-14 18:58       ` Junio C Hamano
2017-02-15 12:32       ` Johannes Schindelin
2017-02-15 20:45         ` Johannes Sixt
2017-02-16 17:10           ` Johannes Schindelin
2017-02-16 17:55             ` Johannes Sixt
2017-02-16 18:01               ` Junio C Hamano [this message]
2017-02-14 18:48     ` Junio C Hamano
2017-02-15 12:48       ` Johannes Schindelin
2017-02-15 22:22         ` Junio C Hamano
2017-02-15 23:34           ` Junio C Hamano
2017-02-17 16:00             ` Johannes Schindelin
2017-02-17 23:49               ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq1suyypyv.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=j6t@kdbg.org \
    --cc=jeffhost@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox