git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Shanti Swarup Tunga <b112041@iiit-bh.ac.in>
Cc: git <git@vger.kernel.org>
Subject: Re: about Starter project;implementing log --size in the print_commit function.
Date: Wed, 25 Mar 2015 09:13:40 -0700	[thread overview]
Message-ID: <xmqq1tkd3vij.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CABJeaiqhL5eNPkaPpheG_Y47Rapj4ys3igHhFH6YuiroECVGDA@mail.gmail.com> (Shanti Swarup Tunga's message of "Mon, 23 Mar 2015 20:45:11 +0530")

Shanti Swarup Tunga <b112041@iiit-bh.ac.in> writes:

> I inserted a size variable of int type and calculated size in each
> cases of print_commit(). The function is
>
> static void print_commit(git_commit *commit)
> {
> ...
> }

See Documentation/SubmittingPatches and then also CodingGuidelines

Especially, explain:

 - what does this change try to help and how?
 - why is this patch a good way to achieve that goal?
 - how the users are expected to use the new feature?

in the proposed log message, run existing tests to make sure your
change did not break the existing system, add tests to make sure
you would notice if somebody else broke the feature you are adding
in the future, and describe the new feature in the documentation.

> Will that approach is going to work for the following problem.?

Was your message cut short?  We cannot read "the following" problem
here...

      reply	other threads:[~2015-03-25 16:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-23 15:15 about Starter project;implementing log --size in the print_commit function Shanti Swarup Tunga
2015-03-25 16:13 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq1tkd3vij.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=b112041@iiit-bh.ac.in \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).