From: Junio C Hamano <gitster@pobox.com>
To: "Srujith A Poojary via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Harald Nordgren <haraldnordgren@gmail.com>,
Usman Akinyemi <usmanakinyemi202@gmail.com>,
Srujith A Poojary <poojarysrujith@gmail.com>
Subject: Re: [PATCH v3] [Outreachy PATCH] t2030: modernize test path checks
Date: Fri, 06 Nov 2026 18:25:45 -0800 [thread overview]
Message-ID: <xmqq33tdbcnq.fsf@gitster.g> (raw)
In-Reply-To: <pull.2256.v3.git.1792299943380.gitgitgadget@gmail.com> (Srujith A. Poojary via GitGitGadget's message of "Sun, 18 Oct 2026 05:05:43 +0000")
"Srujith A Poojary via GitGitGadget" <gitgitgadget@gmail.com>
writes:
> diff --git a/t/t2030-unresolve-info.sh b/t/t2030-unresolve-info.sh
> index 9af24b1204..f6f5dd7cb8 100755
> --- a/t/t2030-unresolve-info.sh
> +++ b/t/t2030-unresolve-info.sh
> @@ -170,7 +170,7 @@ test_expect_success 'rerere and rerere forget' '
> git rerere &&
> rerere_id=$(cd .git/rr-cache && echo */postimage) &&
> rerere_id=${rerere_id%/postimage} &&
> - test -f .git/rr-cache/$rerere_id/postimage &&
> + test_path_is_file .git/rr-cache/$rerere_id/postimage &&
OK.
> - ! test -f .git/rr-cache/$rerere_id/postimage &&
> + test_path_is_missing .git/rr-cache/$rerere_id/postimage &&
OK.
> - test -f .git/rr-cache/$rerere_id/postimage &&
> + test_path_is_file .git/rr-cache/$rerere_id/postimage &&
OK.
> - ! test -f .git/rr-cache/$rerere_id/postimage &&
> + test_path_is_missing .git/rr-cache/$rerere_id/postimage &&
OK.
prev parent reply other threads:[~2026-11-07 2:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 11:52 [PATCH] t2030: modernize test path checks Srujith A Poojary via GitGitGadget
2026-10-16 7:25 ` [PATCH v2] [Outreachy PATCH] " Srujith A Poojary via GitGitGadget
2026-10-16 8:36 ` Harald Nordgren
2026-10-16 8:50 ` Srujith Poojary
2026-10-16 9:35 ` Usman Akinyemi
2026-10-16 10:16 ` Srujith Poojary
2026-10-16 9:18 ` Usman Akinyemi
2026-10-18 5:05 ` [PATCH v3] " Srujith A Poojary via GitGitGadget
2026-11-07 2:25 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq33tdbcnq.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=haraldnordgren@gmail.com \
--cc=poojarysrujith@gmail.com \
--cc=usmanakinyemi202@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox