From: Junio C Hamano <gitster@pobox.com>
To: "Matt Hunter" <m@lfurio.us>
Cc: "Colin Hinton" <colinlewishinton@gmail.com>, <git@vger.kernel.org>
Subject: Re: [PATCH v2] remote.c: defer remote.<name>.followRemoteHEAD validation
Date: Fri, 30 Oct 2026 08:12:16 -0700 [thread overview]
Message-ID: <xmqq33tnz0hb.fsf@gitster.g> (raw)
In-Reply-To: <DMHZCS9LOW3N.ZJ3947HUCXZ8@lfurio.us> (Matt Hunter's message of "Fri, 30 Oct 2026 03:04:55 -0400")
"Matt Hunter" <m@lfurio.us> writes:
> On Wed Oct 28, 2026 at 10:26 AM EDT, Junio C Hamano wrote:
>>
>>>> This part of the code becomes overly deeply indented, and more
>>>> importantly, the outer conditional around here has been reworked by
>>>> another topic and the code that learns follow_remote_head will have
>>>> to be reused elsewhere, which would lead to a nasty merge conflict.
> ...
> I wonder if it makes sense to incorporate such a new helper function
> into the existing 'get_follow_remote_head()', since it would be the only
> place using it.
I am not sure what being the only place has to do with avoiding to
split a helper function out to clarify the main logic flow, though.
And simultaneously, another topic wants to have this piece of logic
twice.
prev parent reply other threads:[~2026-10-30 15:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-18 23:55 [PATCH v1] remote.c: defer remote.<name>.followRemoteHEAD validation Colin Hinton
2026-10-19 15:37 ` Junio C Hamano
2026-10-19 21:24 ` Matt Hunter
2026-10-21 16:30 ` Colin Hinton
2026-10-22 12:39 ` Matt Hunter
2026-10-23 18:50 ` [PATCH v2] " Colin Hinton
2026-10-23 21:59 ` Junio C Hamano
2026-10-24 9:28 ` Matt Hunter
2026-10-24 16:47 ` Junio C Hamano
2026-10-25 2:16 ` Junio C Hamano
2026-10-28 2:56 ` Colin Hinton
2026-10-28 14:26 ` Junio C Hamano
2026-10-30 7:04 ` Matt Hunter
2026-10-30 15:12 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq33tnz0hb.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=colinlewishinton@gmail.com \
--cc=git@vger.kernel.org \
--cc=m@lfurio.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox