Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: kristofferhaugsbakk@fastmail.com
Cc: git@vger.kernel.org,
	"Kristoffer Haugsbakk" <code@khaugsbakk.name>,
	"Patrick Steinhardt" <ps@pks.im>,
	"Jean-Noël Avila" <jn.avila@free.fr>
Subject: Re: [PATCH v4 0/2] doc: format-rev: use [synopsis] on code block
Date: Mon, 17 Aug 2026 14:46:53 -0700	[thread overview]
Message-ID: <xmqq33wc4dyq.fsf@gitster.g> (raw)
In-Reply-To: <V4_CV_synopsis_block.b8e@msgid.xyz> (kristofferhaugsbakk@fastmail.com's message of "Mon, 17 Aug 2026 20:51:47 +0200")

kristofferhaugsbakk@fastmail.com writes:

> From: Kristoffer Haugsbakk <code@khaugsbakk.name>
>
> Topic name (applied): kh/format-rev-doc-synopsis
>
> Topic summary: Use '[synopsis]' on block in order to highlight
> placeholder properly. Also quote the subject consistently.
>
> § Changes in v4
>
> Sorry about not reading carefully. An open block is not a code block.
>
> (copied from the patch note)
>
> Fix block: use open block, not code block.[1] This is what was done for the
> synopsis blocks in commit a34d1d53, the commit mentioned here. I have
> tested this with what I believe are the use-asciidoc (tool) and
> use-asciidoctor (tool):
>
>     make doc
>     make USE_ASCIIDOCTOR=1 doc
>
> And they didn’t give any warnings. And they produced the correct result.
>
>   🔗 1: https://lore.kernel.org/git/xmqqfr0hqzvl.fsf@gitster.g/
>
> Rewrite or flesh out the commit message to reflect this newfound knowledge.
>
> Also remove the Ack since this change invalidates it.
>
> § Cc
>
> (See v2)
>
> § Link to v3
>
> https://lore.kernel.org/git/V3_CV_synopsis_block.b64@msgid.xyz/
>
> [1/2] doc: format-rev: quote subject placeholder before and after
> [2/2] doc: format-rev: use [synopsis] on code block

Hopefully this is now ready for 'next'.

Thanks.

      parent reply	other threads:[~2026-08-17 21:46 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-30 12:02 [PATCH] doc: format-rev: use [synopsis] on code block kristofferhaugsbakk
2026-08-10 16:58 ` [PATCH resend] " kristofferhaugsbakk
2026-08-11 12:32   ` Patrick Steinhardt
2026-08-11 16:23     ` Kristoffer Haugsbakk
2026-08-11 16:27       ` Patrick Steinhardt
2026-08-11 16:30         ` Kristoffer Haugsbakk
2026-08-11 19:38       ` Kristoffer Haugsbakk
2026-08-13  9:57 ` [PATCH v2 0/2] " kristofferhaugsbakk
2026-08-13  9:57   ` [PATCH v2 1/2] doc: format-rev: quote subject placeholder before and after kristofferhaugsbakk
2026-08-13  9:57   ` [PATCH v2 2/2] doc: format-rev: use [synopsis] on code block kristofferhaugsbakk
2026-08-13 10:04     ` Patrick Steinhardt
2026-08-13 14:23 ` [PATCH v3 0/2] " kristofferhaugsbakk
2026-08-13 14:23   ` [PATCH v3 1/2] doc: format-rev: quote subject placeholder before and after kristofferhaugsbakk
2026-08-13 14:23   ` [PATCH v3 2/2] doc: format-rev: use [synopsis] on code block kristofferhaugsbakk
2026-08-14  1:01     ` Junio C Hamano
2026-08-14  7:45       ` Kristoffer Haugsbakk
2026-08-14 14:47         ` Junio C Hamano
2026-08-17 18:51 ` [PATCH v4 0/2] " kristofferhaugsbakk
2026-08-17 18:51   ` [PATCH v4 1/2] doc: format-rev: quote subject placeholder before and after kristofferhaugsbakk
2026-08-17 18:51   ` [PATCH v4 2/2] doc: format-rev: use [synopsis] on code block kristofferhaugsbakk
2026-08-17 21:46   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq33wc4dyq.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=code@khaugsbakk.name \
    --cc=git@vger.kernel.org \
    --cc=jn.avila@free.fr \
    --cc=kristofferhaugsbakk@fastmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox