From: Junio C Hamano <gitster@pobox.com>
To: Tian Yuchen <cat@malon.dev>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v5 0/2] repository: move fetch_if_missing into struct repository
Date: Fri, 14 Aug 2026 07:44:07 -0700 [thread overview]
Message-ID: <xmqq33wgrcco.fsf@gitster.g> (raw)
In-Reply-To: <20260814072419.1666358-1-cat@malon.dev> (Tian Yuchen's message of "Fri, 14 Aug 2026 15:24:17 +0800")
Tian Yuchen <cat@malon.dev> writes:
> Documentation/technical/partial-clone.adoc | 2 +-
> builtin/fetch-pack.c | 6 +++---
> builtin/fsck.c | 6 +++---
> builtin/index-pack.c | 8 +++----
> builtin/pack-objects.c | 25 ++++++++++++----------
> builtin/prune.c | 2 +-
> builtin/rev-list.c | 17 ++++++++-------
> common-init.c | 2 +-
> git.c | 2 +-
> midx-write.c | 2 +-
> odb.c | 4 +---
> odb.h | 8 -------
> repository.c | 1 +
> repository.h | 6 ++++++
> revision.c | 2 +-
> 15 files changed, 47 insertions(+), 46 deletions(-)
$ git grep -e 'the_repository->fetch_if_missing' \
builtin/{fetch-pack,fsck,index-pack,pack-objects,prune,rev-list}.c \
common-init.c midx-write.c odb.c repository.c revision.c
common-init.c: the_repository->fetch_if_missing = 0;
Compared to the previous round, there is no remaining reference to
the_repository's '.fetch_if_missing' member. There is a reference
in common-init.c:setup_environment() that reacts to the
GIT_NO_LAZY_FETCH environment variable, but that does not count.
Much better.
Thanks.
prev parent reply other threads:[~2026-08-14 14:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-15 1:18 [PATCH v1] repository: move fetch_if_missing into struct repository Tian Yuchen
2026-07-15 3:27 ` Junio C Hamano
2026-07-15 4:58 ` Tian Yuchen
2026-07-15 6:35 ` Patrick Steinhardt
2026-07-16 7:06 ` Tian Yuchen
2026-07-16 15:28 ` Junio C Hamano
2026-07-16 7:29 ` [PATCH v2] " Tian Yuchen
2026-08-01 15:53 ` Tian Yuchen
2026-08-04 8:24 ` Patrick Steinhardt
2026-08-04 17:38 ` Junio C Hamano
2026-08-05 12:34 ` Tian Yuchen
2026-08-05 12:10 ` Tian Yuchen
2026-08-07 9:41 ` [PATCH v3] " Tian Yuchen
2026-08-07 17:03 ` Junio C Hamano
2026-08-09 15:00 ` Tian Yuchen
2026-08-13 6:11 ` [PATCH v4] " Tian Yuchen
2026-08-13 16:32 ` Junio C Hamano
2026-08-14 7:24 ` [PATCH v5 0/2] " Tian Yuchen
2026-08-14 7:24 ` [PATCH v5 1/2] pack-objects: give fetch_if_missing call sites access to 'repo' Tian Yuchen
2026-08-14 14:38 ` Junio C Hamano
2026-08-14 7:24 ` [PATCH v5 2/2] repository: move fetch_if_missing into struct repository Tian Yuchen
2026-08-14 14:44 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq33wgrcco.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=cat@malon.dev \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox