From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Mar 2026, #12)
Date: Tue, 31 Mar 2026 08:27:54 -0700 [thread overview]
Message-ID: <xmqq341g3tol.fsf@gitster.g> (raw)
In-Reply-To: <actaFN8ds0cfgWxI@pks.im> (Patrick Steinhardt's message of "Tue, 31 Mar 2026 07:22:28 +0200")
Patrick Steinhardt <ps@pks.im> writes:
> On Mon, Mar 30, 2026 at 05:10:42PM -0700, Junio C Hamano wrote:
>> * ps/commit-graph-overflow-fix (2026-03-23) 1 commit
>> - commit-graph: fix writing generations with dates exceeding 34 bits
>>
>> Fix a regression in writing the commit-graph where commits with dates
>> exceeding 34 bits (beyond year 2514) could cause an underflow and
>> crash Git during the generation data overflow chunk writing.
>>
>> Waiting for review response.
>> cf. <xmqq1ph92pzs.fsf@gitster.g>
>> source: <20260324-pks-commit-graph-overflow-v2-1-843568cf8780@pks.im>
>
> Shall this also be marked as "Will merge to next" based on our last
> discussion at [1]? I mostly want to ensure this is part of rc0 so that
> the regression isn't part of any tagged release, even if it's just a
> release candidate.
Even though I still feel uncomfortable hurrying to merge down an
obviously UB code, instead of an uglier but far safer conditional
compilation, patching it on top is trivial, so let's mark it for
'next'. Thanks for spotting.
prev parent reply other threads:[~2026-03-31 15:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 0:10 What's cooking in git.git (Mar 2026, #12) Junio C Hamano
2026-03-31 0:20 ` Mirko Faina
2026-03-31 15:15 ` Junio C Hamano
2026-03-31 5:22 ` Patrick Steinhardt
2026-03-31 15:27 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq341g3tol.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox