From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Mahi Kassa <mahlet.takassa@gmail.com>,
git@vger.kernel.org, lucasseikioshiro@gmail.com,
jltobler@gmail.com
Subject: Re: [PATCH v3] repo: show subcommand-specific help text
Date: Wed, 25 Mar 2026 09:55:08 -0700 [thread overview]
Message-ID: <xmqq341nx30z.fsf@gitster.g> (raw)
In-Reply-To: <acOye5MbsFVOa1vJ@pks.im> (Patrick Steinhardt's message of "Wed, 25 Mar 2026 11:01:31 +0100")
Patrick Steinhardt <ps@pks.im> writes:
>> v3:
>> - include the requested code changes that were missing from v2
>> - factor shared usage strings into macros to avoid duplication
>> - restore blank lines between tests and before test_done
>
> By the way, it is highly recommended to respond to some of the review
> mails directly, as it helps to create a dialog between submitter and
> reviewer. Otherwise reviewers may feel as if they are talking to a code
> emitting entity :)
>
> It's not necessary to reply to every single mail, but going like "Oops,
> yes, I indeed forgot to add the request code changes. Will fix in the
> next version" can go a long way to make the interaction more social.
Hear! hear! A new iteration without any introduction is harder to
accept without such a pre-warning to suggest what the author thought
after getting suggestions in earlier reviews. Did they agree and
took the suggestion? Did they disagree but took the suggestion
anyway, and if so why did they think the suggestion was not such a
good change? Did they disagree and did not take the suggestion and
if so why? They changed the code but not in the way suggested in
the review, but why the new way was thought to be better than both
the original and the reviewer input is unknown?
prev parent reply other threads:[~2026-03-25 16:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 15:29 [PATCH] repo: show subcommand-specific help text Mahi Kassa
2026-03-23 19:32 ` Derrick Stolee
2026-03-24 6:26 ` Patrick Steinhardt
2026-03-24 12:21 ` [PATCH v2] " Mahi Kassa
2026-03-24 12:52 ` Patrick Steinhardt
2026-03-24 17:07 ` Derrick Stolee
2026-03-24 18:48 ` [PATCH v3] " Mahi Kassa
2026-03-24 19:15 ` Derrick Stolee
2026-03-25 10:01 ` Patrick Steinhardt
2026-03-25 16:55 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq341nx30z.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jltobler@gmail.com \
--cc=lucasseikioshiro@gmail.com \
--cc=mahlet.takassa@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox