From: Junio C Hamano <gitster@pobox.com>
To: Collin Funk <collin.funk1@gmail.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [PATCH v2 2/2] gpg-interface: remove an unnecessary NULL initialization
Date: Thu, 05 Feb 2026 17:59:13 -0800 [thread overview]
Message-ID: <xmqq343ek4y6.fsf@gitster.g> (raw)
In-Reply-To: <8d188ce1b8994f0108b49a4cad8af425b09504fd.1770342268.git.collin.funk1@gmail.com> (Collin Funk's message of "Thu, 5 Feb 2026 17:46:10 -0800")
Collin Funk <collin.funk1@gmail.com> writes:
> We assign this variable unconditionally, so we do not need to assign it
> to NULL where it is declared.
The latter "assign" is better phrased as "initialize", but other
than that this looks great.
Thanks.
>
> Signed-off-by: Collin Funk <collin.funk1@gmail.com>
> ---
> gpg-interface.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gpg-interface.c b/gpg-interface.c
> index 377c0cf49f..87fb6605fb 100644
> --- a/gpg-interface.c
> +++ b/gpg-interface.c
> @@ -398,7 +398,7 @@ static void parse_ssh_output(struct signature_check *sigc)
> {
> const char *line, *principal, *search;
> char *to_free;
> - const char *key = NULL;
> + const char *key;
>
> /*
> * ssh-keygen output should be:
next prev parent reply other threads:[~2026-02-06 1:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-05 3:24 [PATCH] global: constify some pointers that are not written to Collin Funk
2026-02-05 7:41 ` Jeff King
2026-02-05 17:49 ` Junio C Hamano
2026-02-05 22:00 ` Collin Funk
2026-02-06 1:46 ` [PATCH v2 1/2] " Collin Funk
2026-02-06 1:46 ` [PATCH v2 2/2] gpg-interface: remove an unnecessary NULL initialization Collin Funk
2026-02-06 1:59 ` Junio C Hamano [this message]
2026-02-06 15:54 ` [PATCH v2 1/2] global: constify some pointers that are not written to Ben Knoble
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq343ek4y6.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=collin.funk1@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox