From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org, Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] refs/files: deprecate writing symrefs as symbolic links
Date: Wed, 15 Oct 2025 07:49:45 -0700 [thread overview]
Message-ID: <xmqq347kw77a.fsf@gitster.g> (raw)
In-Reply-To: <aO84NamCzFXH1eUl@pks.im> (Patrick Steinhardt's message of "Wed, 15 Oct 2025 07:59:17 +0200")
Patrick Steinhardt <ps@pks.im> writes:
> I don't think we do. I'll say "textual symref format" here.
>
>> > + warn_once = 0;
>> > +
>> > + ref_path = get_locked_file_path(&lock->lk);
>>
>> Was there a reason why we want to first warn and then attempt to
>> lock? We are afraid that we may die before we have a chance to
>> warn()?
>
> No particular reason, no. Happy to move it towards the end so that error
> messages are given preference.
I have no strong preference. I just wondered if there were deep
reason that was unexplained behind this change.
next prev parent reply other threads:[~2025-10-15 14:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 8:17 [PATCH] refs/files: deprecate writing symrefs as symbolic links Patrick Steinhardt
2025-10-14 17:23 ` Junio C Hamano
2025-10-15 5:59 ` Patrick Steinhardt
2025-10-15 14:49 ` Junio C Hamano [this message]
2025-10-15 6:26 ` [PATCH v2] " Patrick Steinhardt
2025-10-15 16:15 ` Junio C Hamano
2025-10-23 20:54 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq347kw77a.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).