From: Junio C Hamano <gitster@pobox.com>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: "René Scharfe" <l.s.r@web.de>, "Git List" <git@vger.kernel.org>
Subject: Re: [PATCH] for-each-ref: call --start-after argument "marker"
Date: Tue, 12 Aug 2025 07:33:31 -0700 [thread overview]
Message-ID: <xmqq349wy5hg.fsf@gitster.g> (raw)
In-Reply-To: <CAOLa=ZQGaZA=Yynv5JkYpSbYBczfVnemwmzABrqB6er19Utfeg@mail.gmail.com> (Karthik Nayak's message of "Tue, 12 Aug 2025 02:08:55 -0700")
Karthik Nayak <karthik.188@gmail.com> writes:
> Junio C Hamano <gitster@pobox.com> writes:
>
>> Karthik Nayak <karthik.188@gmail.com> writes:
>>
>>>> - OPT_STRING( 0 , "start-after", &filter.start_after, N_("start-after"), N_("start iteration after the provided marker")),
>>>> + OPT_STRING( 0 , "start-after", &filter.start_after, N_("marker"), N_("start iteration after the provided marker")),
>>>>
>>>
>>> Ah! I did fix a typo here, but your fix is better. Thanks.
>>
>> Here where? Is that "fix a typo" something I should go around and
>> make sure I do not miss?
>
> I meant my earlier patch fa0f4e46f5 (for-each-ref: reword the
> documentation for '--start-after', 2025-07-28) which is merged to master
> now.
Hmph, so what does mentioning of your earlier typofix add to review
of this new patch? We should revert your earlier change and replace
it with this one? Or there were two typos, you fixed only one, and
this patch ties a loose end left by it (but then that is not what
I'd describe "yours is better", so I am still puzzled)?
Thanks.
next prev parent reply other threads:[~2025-08-12 14:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-09 8:29 [PATCH] for-each-ref: call --start-after argument "marker" René Scharfe
2025-08-10 0:06 ` Junio C Hamano
2025-08-11 9:19 ` Karthik Nayak
2025-08-11 15:59 ` Junio C Hamano
2025-08-12 9:08 ` Karthik Nayak
2025-08-12 14:33 ` Junio C Hamano [this message]
2025-08-12 14:36 ` Karthik Nayak
2025-08-12 15:07 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq349wy5hg.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).