From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: [PATCH 1/3] curl: fix integer constant typechecks with curl_easy_setopt()
Date: Thu, 05 Jun 2025 16:13:04 -0700 [thread overview]
Message-ID: <xmqq34cd7pfj.fsf@gitster.g> (raw)
In-Reply-To: <20250605225144.GD3005733@coredump.intra.peff.net> (Jeff King's message of "Thu, 5 Jun 2025 18:51:44 -0400")
Jeff King <peff@peff.net> writes:
> On Thu, Jun 05, 2025 at 06:49:10PM -0400, Jeff King wrote:
>
>> On Thu, Jun 05, 2025 at 09:04:15AM -0700, Junio C Hamano wrote:
>>
>> > --- >8 ---
>> > From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
>> > Date: Thu, 5 Jun 2025 12:57:35 +0200
>> > Subject: [PATCH] curl: pass `long` values where expected
>> >
>> > A set of patches posted by Jeff King earlier covered some fallouts
>> > coming from new typecheck warnings cURL 8.14.0. Here are to fix
>> > some more instances of the same new compile errors observed in the
>> > `osx-gcc` job of Git's CI builds.
>> >
>> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
>> > Signed-off-by: Junio C Hamano <gitster@pobox.com>
>>
>> Thanks, this patch looks good, and I think applying on top is a bit less
>> work. I don't mind integrating them appropriately and re-rolling if we
>> prefer a slightly cleaner history, though. (I don't think there's much
>> value in recording which hit macOS and which did not).
Yeah, other than giving a quick access to the places that only broke
macOS for those who are curious enough and want to find out why ;-)
> Ah, nevermind, my patches are already in next, so building on top is
> definitely best.
Yeah, in any case, taking all four of your patches together, with
Dscho's t5410 "does tee hang?" fix, finally lets the tip of 'seen'
pass without forcing retests.
next prev parent reply other threads:[~2025-06-05 23:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 20:55 [PATCH 0/3] silencing warnings with curl 8.14 Jeff King
2025-06-04 20:55 ` [PATCH 1/3] curl: fix integer constant typechecks with curl_easy_setopt() Jeff King
2025-06-05 10:57 ` Johannes Schindelin
2025-06-05 16:04 ` Junio C Hamano
2025-06-05 22:49 ` Jeff King
2025-06-05 22:51 ` Jeff King
2025-06-05 23:13 ` Junio C Hamano [this message]
2025-06-05 22:47 ` Jeff King
2025-06-04 20:55 ` [PATCH 2/3] curl: fix integer variable " Jeff King
2025-06-04 20:56 ` [PATCH 3/3] curl: fix symbolic constant " Jeff King
2025-06-04 21:25 ` Junio C Hamano
2025-06-05 6:13 ` Daniel Stenberg
2025-06-05 7:25 ` Jeff King
2025-06-04 21:23 ` [PATCH 0/3] silencing warnings with curl 8.14 Collin Funk
2025-06-04 22:03 ` Ramsay Jones
2025-06-05 5:21 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq34cd7pfj.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).