From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>,
Phillip Wood via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>,
Elijah Newren <newren@gmail.com>,
Phillip Wood <phillip.wood@dunelm.org.uk>
Subject: Re: [PATCH] [RFC] rebase -m: partial support for copying extra commit headers
Date: Wed, 09 Apr 2025 08:36:15 -0700 [thread overview]
Message-ID: <xmqq34ehtki8.fsf@gitster.g> (raw)
In-Reply-To: <7f744f34-050c-4d8b-b5fc-aae622c3c5b6@gmail.com> (Phillip Wood's message of "Wed, 9 Apr 2025 15:11:19 +0100")
Phillip Wood <phillip.wood123@gmail.com> writes:
> That's true and we could have a config key to select which "extra"
> headers are propagated.
No, please don't. No such config key should ever exist.
If something has a defined semantics, which all projects that use
Git can agree on, that is solid enough to deserve to be in the
header part of the commit object (as opposed to one of the trailers
with user-defined semantics that can vary from project to project),
there should never be a way to give it different semantics by
tweaking whether it is or it is not propagated when rewriting.
prev parent reply other threads:[~2025-04-09 15:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 15:52 [PATCH] [RFC] rebase -m: partial support for copying extra commit headers Phillip Wood via GitGitGadget
2025-04-08 1:22 ` brian m. carlson
2025-04-08 10:15 ` Phillip Wood
2025-04-08 14:44 ` Junio C Hamano
2025-04-09 14:11 ` Phillip Wood
2025-04-09 15:36 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq34ehtki8.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=newren@gmail.com \
--cc=phillip.wood123@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
--cc=ps@pks.im \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).