From: Junio C Hamano <gitster@pobox.com>
To: Karthik Nayak via B4 Relay <devnull+karthik.188.gmail.com@kernel.org>
Cc: git@vger.kernel.org, Karthik Nayak <karthik.188@gmail.com>
Subject: Re: [PATCH 4/5] pack-write: pass hash_algo to `write_rev_file()`
Date: Thu, 16 Jan 2025 11:35:15 -0800 [thread overview]
Message-ID: <xmqq34hir1qk.fsf@gitster.g> (raw)
In-Reply-To: <20250116-kn-the-repo-cleanup-v1-4-a2f4c8e1c4c3@gmail.com> (Karthik Nayak via's message of "Thu, 16 Jan 2025 12:35:16 +0100")
Karthik Nayak via B4 Relay
<devnull+karthik.188.gmail.com@kernel.org> writes:
> From: Karthik Nayak <karthik.188@gmail.com>
>
> The `write_rev_file()` function uses the global `the_hash_algo` variable
> to access the repository's hash function. To avoid global variable
> usage, let's pass the hash function from the layers above.
There are a few other functions that got an extra git_hash_algo
parameter in this patch. The changes to them all look sensible,
but it would be nice to mention them here.
next prev parent reply other threads:[~2025-01-16 19:35 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 11:35 [PATCH 0/5] pack-write: cleanup usage of global variables Karthik Nayak via B4 Relay
2025-01-16 11:35 ` [PATCH 1/5] pack-write: pass hash_algo to `fixup_pack_header_footer()` Karthik Nayak via B4 Relay
2025-01-16 19:35 ` Junio C Hamano
2025-01-16 11:35 ` [PATCH 2/5] pack-write: pass repository to `index_pack_lockfile()` Karthik Nayak via B4 Relay
2025-01-16 19:05 ` Junio C Hamano
2025-01-17 8:47 ` Karthik Nayak
2025-01-16 11:35 ` [PATCH 3/5] pack-write: pass hash_algo to `write_idx_file()` Karthik Nayak via B4 Relay
2025-01-16 13:24 ` Patrick Steinhardt
2025-01-17 8:56 ` Karthik Nayak
2025-01-16 19:12 ` Junio C Hamano
2025-01-17 8:58 ` Karthik Nayak
2025-01-16 11:35 ` [PATCH 4/5] pack-write: pass hash_algo to `write_rev_file()` Karthik Nayak via B4 Relay
2025-01-16 13:24 ` Patrick Steinhardt
2025-01-16 19:35 ` Junio C Hamano [this message]
2025-01-16 11:35 ` [PATCH 5/5] pack-write: pass hash_algo to `write_rev_*()` Karthik Nayak via B4 Relay
2025-01-17 9:20 ` [PATCH v2 0/5] pack-write: cleanup usage of global variables Karthik Nayak
2025-01-17 9:20 ` [PATCH v2 1/5] pack-write: pass hash_algo to `fixup_pack_header_footer()` Karthik Nayak
2025-01-17 16:38 ` Toon Claes
2025-01-17 18:06 ` Junio C Hamano
2025-01-19 11:07 ` Karthik Nayak
2025-01-17 9:20 ` [PATCH v2 2/5] pack-write: pass repository to `index_pack_lockfile()` Karthik Nayak
2025-01-17 9:20 ` [PATCH v2 3/5] pack-write: pass hash_algo to `write_idx_file()` Karthik Nayak
2025-01-17 16:40 ` Toon Claes
2025-01-19 11:10 ` Karthik Nayak
2025-01-17 9:20 ` [PATCH v2 4/5] pack-write: pass hash_algo to `write_rev_file()` Karthik Nayak
2025-01-17 9:20 ` [PATCH v2 5/5] pack-write: pass hash_algo to internal functions Karthik Nayak
2025-01-17 9:46 ` Patrick Steinhardt
2025-01-17 9:55 ` Karthik Nayak
2025-01-19 11:19 ` [PATCH v3 0/5] pack-write: cleanup usage of global variables Karthik Nayak
2025-01-19 11:19 ` [PATCH v3 1/5] pack-write: pass hash_algo to `fixup_pack_header_footer()` Karthik Nayak
2025-01-19 11:19 ` [PATCH v3 2/5] pack-write: pass repository to `index_pack_lockfile()` Karthik Nayak
2025-01-19 11:19 ` [PATCH v3 3/5] pack-write: pass hash_algo to `write_idx_file()` Karthik Nayak
2025-01-19 11:19 ` [PATCH v3 4/5] pack-write: pass hash_algo to `write_rev_file()` Karthik Nayak
2025-01-19 11:19 ` [PATCH v3 5/5] pack-write: pass hash_algo to internal functions Karthik Nayak
2025-01-24 5:46 ` [PATCH v3 0/5] pack-write: cleanup usage of global variables Patrick Steinhardt
2025-01-24 15:47 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq34hir1qk.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=devnull+karthik.188.gmail.com@kernel.org \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).