From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: Jeff King <peff@peff.net>, Philip Yung <y5c4l3@proton.me>,
Y5 via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] diff: setup pager only before diff contents truly ready
Date: Mon, 18 Nov 2024 09:55:06 +0900 [thread overview]
Message-ID: <xmqq34jpl5sl.fsf@gitster.g> (raw)
In-Reply-To: <ZxatqdBiB+NoMP+j@nand.local> (Taylor Blau's message of "Mon, 21 Oct 2024 15:38:17 -0400")
Taylor Blau <me@ttaylorr.com> writes:
>> You'd need to identify all of the possible diff code paths in order to
>> add tests for them, which is the same thing you had to do to fix the
>> code paths. I was mostly just commenting that we're not likely to be
>> able to rely on existing tests to help us here.
>>
>> It might be worth adding a test that shows off your improved diff
>> behavior, though I would be OK if it was a representative command and
>> not exhaustive. I think adding to t7006 should be fine.
>
> Agreed.
It seems that this topic is waiting for a reroll?
next prev parent reply other threads:[~2024-11-18 0:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-19 20:39 [PATCH] diff: setup pager only before diff contents truly ready Y5 via GitGitGadget
2024-10-19 20:57 ` Kristoffer Haugsbakk
2024-10-21 0:17 ` Philip Yung
2024-10-19 21:19 ` Jeff King
2024-10-21 0:11 ` Philip Yung
2024-10-21 19:00 ` Jeff King
2024-10-21 19:38 ` Taylor Blau
2024-11-18 0:55 ` Junio C Hamano [this message]
2024-11-25 11:31 ` Jeff King
2024-12-03 5:33 ` Junio C Hamano
2024-12-03 21:24 ` Jeff King
2024-12-04 0:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq34jpl5sl.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
--cc=y5c4l3@proton.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).