git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Elijah Newren via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org,  Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH 2/2] doc: correct misleading descriptions for --shallow-exclude
Date: Mon, 04 Nov 2024 22:55:00 -0800	[thread overview]
Message-ID: <xmqq34k6tbjv.fsf@gitster.g> (raw)
In-Reply-To: <Zym6723csrUdiC5A@pks.im> (Patrick Steinhardt's message of "Tue, 5 Nov 2024 07:27:59 +0100")

Patrick Steinhardt <ps@pks.im> writes:

> On Mon, Nov 04, 2024 at 07:02:44PM +0000, Elijah Newren via GitGitGadget wrote:
>> diff --git a/builtin/clone.c b/builtin/clone.c
>> index 59fcb317a68..93fe6d69659 100644
>> --- a/builtin/clone.c
>> +++ b/builtin/clone.c
>> @@ -147,7 +147,7 @@ static struct option builtin_clone_options[] = {
>>  		    N_("create a shallow clone of that depth")),
>>  	OPT_STRING(0, "shallow-since", &option_since, N_("time"),
>>  		    N_("create a shallow clone since a specific time")),
>> -	OPT_STRING_LIST(0, "shallow-exclude", &option_not, N_("revision"),
>> +	OPT_STRING_LIST(0, "shallow-exclude", &option_not, N_("ref"),
>>  			N_("deepen history of shallow clone, excluding rev")),
>
> We also need to replace "rev" with "ref" here. We already do that in the
> other cases.

Ah, I missed that one.  Let me locally amend, as there does not seem
to be any other issues.

  reply	other threads:[~2024-11-05  6:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-04 19:02 [PATCH 0/2] A few --shallow-exclude fixes Elijah Newren via GitGitGadget
2024-11-04 19:02 ` [PATCH 1/2] upload-pack: fix ambiguous error message Elijah Newren via GitGitGadget
2024-11-05  6:27   ` Patrick Steinhardt
2024-11-04 19:02 ` [PATCH 2/2] doc: correct misleading descriptions for --shallow-exclude Elijah Newren via GitGitGadget
2024-11-05  6:27   ` Patrick Steinhardt
2024-11-05  6:55     ` Junio C Hamano [this message]
2024-11-05  1:27 ` [PATCH 0/2] A few --shallow-exclude fixes Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq34k6tbjv.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=newren@gmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).