git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: git@vger.kernel.org,  steadmon@google.com,
	 hanyang.tony@bytedance.com, me@ttaylorr.com
Subject: Re: [PATCH v2 0/4] When fetching from a promisor remote, repack local objects referenced
Date: Sun, 03 Nov 2024 18:05:05 -0800	[thread overview]
Message-ID: <xmqq34k7ycry.fsf@gitster.g> (raw)
In-Reply-To: <xmqq7c9jyhjb.fsf@gitster.g> (Junio C. Hamano's message of "Sun, 03 Nov 2024 16:22:16 -0800")

Junio C Hamano <gitster@pobox.com> writes:

> You may already have noticed this, but with this topic merged,
> 'seen' seems to start failing leak checker jobs e.g.
>
> https://github.com/git/git/actions/runs/11642458705
>   https://github.com/git/git/actions/runs/11642458705/job/32422074222#step:4:1964
>   https://github.com/git/git/actions/runs/11642458705/job/32422074132#step:4:1963

With this patch, t5300 no longer seems to leak (when the topic is
tested alone, at least).

 builtin/index-pack.c | 1 +
 1 file changed, 1 insertion(+)

diff --git c/builtin/index-pack.c w/builtin/index-pack.c
index e4afd6725f..08b340552f 100644
--- c/builtin/index-pack.c
+++ w/builtin/index-pack.c
@@ -1821,6 +1821,7 @@ static void repack_local_links(void)
 	if (finish_command(&cmd))
 		die(_("could not finish pack-objects to repack local links"));
 	strbuf_release(&line);
+	free(base_name);
 }
 
 int cmd_index_pack(int argc,

      reply	other threads:[~2024-11-04  2:05 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-24 18:08 [PATCH 0/5] When fetching from a promisor remote, repack local objects referenced Jonathan Tan
2024-10-24 18:08 ` [PATCH 1/5] pack-objects: make variable non-static Jonathan Tan
2024-10-28  0:30   ` Taylor Blau
2024-10-28 19:34     ` Jonathan Tan
2024-10-28 19:50       ` Taylor Blau
2024-10-28 23:04         ` Jonathan Tan
2024-10-24 18:08 ` [PATCH 2/5] t0410: make test description clearer Jonathan Tan
2024-10-24 18:08 ` [PATCH 3/5] t0410: use from-scratch server Jonathan Tan
2024-10-24 18:08 ` [PATCH 4/5] t5300: move --window clamp test next to unclamped Jonathan Tan
2024-10-24 18:08 ` [PATCH 5/5] index-pack: repack local links into promisor packs Jonathan Tan
2024-10-30 22:29   ` Josh Steadmon
2024-11-01 20:14     ` Jonathan Tan
2024-10-25  6:04 ` [External] [PATCH 0/5] When fetching from a promisor remote, repack local objects referenced Han Young
2024-10-25 21:07   ` Taylor Blau
2024-11-02 10:38     ` Junio C Hamano
2024-10-25 21:07 ` Taylor Blau
2024-11-01 20:11 ` [PATCH v2 0/4] " Jonathan Tan
2024-11-01 20:11   ` [PATCH v2 1/4] t0410: make test description clearer Jonathan Tan
2024-11-01 20:11   ` [PATCH v2 2/4] t0410: use from-scratch server Jonathan Tan
2024-11-01 20:11   ` [PATCH v2 3/4] t5300: move --window clamp test next to unclamped Jonathan Tan
2024-11-13  7:35     ` Jeff King
2024-11-13 18:26       ` Jonathan Tan
2024-11-14  0:56         ` Jeff King
2024-11-14  6:41           ` Junio C Hamano
2024-11-15  9:52             ` Jeff King
2024-11-15 19:55           ` Jonathan Tan
2024-11-16  3:23             ` Jeff King
2024-11-18 19:02               ` [PATCH] index-pack: teach --promisor to require --stdin Jonathan Tan
2024-11-19  3:29                 ` Junio C Hamano
2024-11-19 18:53                 ` Jeff King
2024-11-20  1:34                   ` Junio C Hamano
2024-11-19 20:10               ` [PATCH v2] index-pack: teach --promisor to forbid pack name Jonathan Tan
2024-11-20  6:29                 ` Jeff King
2024-11-14  0:59       ` [PATCH v2 3/4] t5300: move --window clamp test next to unclamped Jeff King
2024-11-01 20:11   ` [PATCH v2 4/4] index-pack: repack local links into promisor packs Jonathan Tan
2024-11-04  0:22   ` [PATCH v2 0/4] When fetching from a promisor remote, repack local objects referenced Junio C Hamano
2024-11-04  2:05     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq34k7ycry.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=hanyang.tony@bytedance.com \
    --cc=jonathantanmy@google.com \
    --cc=me@ttaylorr.com \
    --cc=steadmon@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).