From: Junio C Hamano <gitster@pobox.com>
To: Philippe Blain <levraiphilippeblain@gmail.com>
Cc: Patrick Steinhardt <ps@pks.im>,
Philippe Blain via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] Makefile: fix dependency for $(UNIT_TEST_DIR)/clar/clar.o
Date: Thu, 10 Oct 2024 11:50:34 -0700 [thread overview]
Message-ID: <xmqq34l3lrlx.fsf@gitster.g> (raw)
In-Reply-To: <C05B01E0-5007-4FB9-94CD-CBE74E79F9B7@gmail.com> (Philippe Blain's message of "Thu, 10 Oct 2024 08:04:10 -0400")
Philippe Blain <levraiphilippeblain@gmail.com> writes:
> I had a closer look at how the header dependencies are handled in
> the Makefile and I think a cleaner and more idiomatic way to fix
> the problem would be to add clar.suite to GENERATED_H.
If it is a header file (e.g. we could run "make hdr-check" on it to
make sure it is self-contained, if we wanted to check it), that
sounds like a very appropriate thing to do.
> I’ll try to send a v2 tomorrow so maybe hold on to merging it to
> next for the moment, Junio.
Thanks.
next prev parent reply other threads:[~2024-10-10 18:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 17:43 [PATCH] Makefile: fix dependency for $(UNIT_TEST_DIR)/clar/clar.o Philippe Blain via GitGitGadget
2024-10-08 0:53 ` Junio C Hamano
2024-10-08 3:58 ` Patrick Steinhardt
2024-10-10 12:04 ` Philippe Blain
2024-10-10 18:50 ` Junio C Hamano [this message]
2024-10-11 17:29 ` [PATCH v2] " Philippe Blain via GitGitGadget
2024-10-14 11:59 ` Patrick Steinhardt
2024-10-15 0:34 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq34l3lrlx.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=levraiphilippeblain@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).