From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: Ghanshyam Thakkar <shyamthakkar001@gmail.com>,
git@vger.kernel.org, Christian Couder <chriscool@tuxfamily.org>,
Kaartic Sivaraam <kaartic.sivaraam@gmail.com>,
Josh Steadmon <steadmon@google.com>,
Phillip Wood <phillip.wood123@gmail.com>
Subject: Re: [GSoC][PATCH v5] t: port helper/test-hashmap.c to unit-tests/t-hashmap.c
Date: Wed, 07 Aug 2024 09:20:28 -0700 [thread overview]
Message-ID: <xmqq34ngpann.fsf@gitster.g> (raw)
In-Reply-To: <CAP8UFD3VwiAbGvzgi14EcEQLX6Gs7pNy+dvZcXkPOueKpJS7HA@mail.gmail.com> (Christian Couder's message of "Wed, 7 Aug 2024 16:33:43 +0200")
Christian Couder <christian.couder@gmail.com> writes:
>> Range-diff against v4:
>
> Nit (not worth a reroll): the range-diff usually goes before the
> actual patch in the section starting with a line containing only 3
> dashes
This comes from https://lore.kernel.org/git/Zk7UsJjhY_FV2z8C@tanuki/
that eventually became 2fa04ceb (format-patch: move range/inter diff
at the end of a single patch output, 2024-05-24).
prev parent reply other threads:[~2024-08-07 16:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-28 12:41 [GSoC][PATCH] t: port helper/test-hashmap.c to unit-tests/t-hashmap.c Ghanshyam Thakkar
2024-07-08 16:15 ` [GSoC][PATCH v2] " Ghanshyam Thakkar
2024-07-09 19:34 ` Josh Steadmon
2024-07-09 21:42 ` Junio C Hamano
2024-07-10 19:41 ` Ghanshyam Thakkar
2024-07-09 23:27 ` Ghanshyam Thakkar
2024-07-10 10:19 ` Phillip Wood
2024-07-11 18:54 ` Ghanshyam Thakkar
2024-07-11 23:51 ` [GSoC][PATCH v3] " Ghanshyam Thakkar
2024-07-12 0:00 ` Ghanshyam Thakkar
2024-07-12 17:14 ` Junio C Hamano
2024-07-25 12:48 ` Christian Couder
2024-07-30 11:50 ` [PATCH v4] " A U Thor
2024-07-31 17:18 ` Christian Couder
2024-07-31 18:50 ` Junio C Hamano
2024-08-02 2:28 ` Ghanshyam Thakkar
2024-08-03 13:34 ` [GSoC][PATCH v5] " Ghanshyam Thakkar
2024-08-07 14:33 ` Christian Couder
2024-08-07 14:44 ` Ghanshyam Thakkar
2024-08-07 16:20 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq34ngpann.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=kaartic.sivaraam@gmail.com \
--cc=phillip.wood123@gmail.com \
--cc=shyamthakkar001@gmail.com \
--cc=steadmon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).