From: Junio C Hamano <gitster@pobox.com>
To: Kyle Lippincott <spectral@google.com>
Cc: "Eric Sunshine" <ericsunshine@charter.net>,
git@vger.kernel.org, "Rubén Justo" <rjusto@gmail.com>,
"Eric Sunshine" <sunshine@sunshineco.com>
Subject: Re: [PATCH 3/4] check-non-portable-shell: improve `VAR=val shell-func` detection
Date: Mon, 22 Jul 2024 11:10:52 -0700 [thread overview]
Message-ID: <xmqq34o1cn6b.fsf@gitster.g> (raw)
In-Reply-To: <CAO_smVg8+WCG0dWZNPVbDM4gBJLLHrg96nOCzje6B3hUGneDGg@mail.gmail.com> (Kyle Lippincott's message of "Mon, 22 Jul 2024 10:26:10 -0700")
Kyle Lippincott <spectral@google.com> writes:
> Is there an example of a shell on Linux that has this behavior that I
> can observe, and/or reproduction steps?
Every once in a while this comes up and we fix, e.g.
https://lore.kernel.org/git/528CE716.8060307@ramsay1.demon.co.uk/
https://lore.kernel.org/git/c6efda03848abc00cf8bf8d84fc34ef0d652b64c.1264151435.git.mhagger@alum.mit.edu/
https://lore.kernel.org/git/Koa4iojOlOQ_YENPwWXKt7G8Aa1x6UaBnFFtliKdZmpcrrqOBhY7NQ@cipher.nrlssc.navy.mil/
https://lore.kernel.org/git/20180713055205.32351-2-sunshine@sunshineco.com/
https://lore.kernel.org/git/574E27A4.6040804@ramsayjones.plus.com/
which is from a query
https://lore.kernel.org/git/?q=one-shot+export+shell+function
but unfortunately we do not document which exact shell the observed
breakage happened with.
The closest article I found that is suitable as a discussion
reignitor talks about what POSIX requires, which may be more
relevant:
https://lore.kernel.org/git/4B5027B8.2090507@viscovery.net/
next prev parent reply other threads:[~2024-07-22 18:10 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-22 6:59 [PATCH 0/4] improve one-shot variable detection with shell function Eric Sunshine
2024-07-22 6:59 ` [PATCH 1/4] t3430: modernize one-shot "VAR=val shell-func" invocation Eric Sunshine
2024-07-22 15:09 ` Phillip Wood
2024-07-23 9:26 ` Phillip Wood
2024-07-26 6:33 ` Eric Sunshine
2024-07-26 6:15 ` Eric Sunshine
2024-07-22 18:24 ` Junio C Hamano
2024-07-26 6:30 ` Eric Sunshine
2024-07-22 6:59 ` [PATCH 2/4] t4034: fix use of one-shot variable assignment with shell function Eric Sunshine
2024-07-22 6:59 ` [PATCH 3/4] check-non-portable-shell: improve `VAR=val shell-func` detection Eric Sunshine
2024-07-22 14:46 ` Rubén Justo
2024-07-26 6:45 ` Eric Sunshine
2024-07-26 13:15 ` Rubén Justo
2024-07-22 17:26 ` Kyle Lippincott
2024-07-22 18:10 ` Junio C Hamano [this message]
2024-07-22 21:35 ` Kyle Lippincott
2024-07-22 21:57 ` Junio C Hamano
2024-07-22 6:59 ` [PATCH 4/4] check-non-portable-shell: suggest alternative for `VAR=val shell-func` Eric Sunshine
2024-07-22 14:47 ` Rubén Justo
2024-07-22 14:50 ` [PATCH 0/4] improve one-shot variable detection with shell function Rubén Justo
2024-07-26 8:15 ` [PATCH v2 0/5] " Eric Sunshine
2024-07-26 8:15 ` [PATCH v2 1/5] t3430: drop unnecessary one-shot "VAR=val shell-func" invocation Eric Sunshine
2024-07-26 18:50 ` Junio C Hamano
2024-07-26 19:32 ` Eric Sunshine
2024-07-26 8:15 ` [PATCH v2 2/5] t4034: fix use of one-shot variable assignment with shell function Eric Sunshine
2024-07-26 8:15 ` [PATCH v2 3/5] check-non-portable-shell: loosen one-shot assignment error message Eric Sunshine
2024-07-26 8:15 ` [PATCH v2 4/5] check-non-portable-shell: suggest alternative for `VAR=val shell-func` Eric Sunshine
2024-07-26 13:11 ` Rubén Justo
2024-07-26 19:31 ` Eric Sunshine
2024-07-26 8:15 ` [PATCH v2 5/5] check-non-portable-shell: improve `VAR=val shell-func` detection Eric Sunshine
2024-07-26 18:38 ` [PATCH v2 0/5] improve one-shot variable detection with shell function Junio C Hamano
2024-07-27 5:35 ` [PATCH v3 " Eric Sunshine
2024-07-27 5:35 ` [PATCH v3 1/5] t3430: drop unnecessary one-shot "VAR=val shell-func" invocation Eric Sunshine
2024-07-27 5:35 ` [PATCH v3 2/5] t4034: fix use of one-shot variable assignment with shell function Eric Sunshine
2024-07-27 5:35 ` [PATCH v3 3/5] check-non-portable-shell: loosen one-shot assignment error message Eric Sunshine
2024-07-27 5:35 ` [PATCH v3 4/5] check-non-portable-shell: suggest alternative for `VAR=val shell-func` Eric Sunshine
2024-07-27 5:35 ` [PATCH v3 5/5] check-non-portable-shell: improve `VAR=val shell-func` detection Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq34o1cn6b.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=ericsunshine@charter.net \
--cc=git@vger.kernel.org \
--cc=rjusto@gmail.com \
--cc=spectral@google.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).