From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: Philippe Blain <levraiphilippeblain@gmail.com>,
Git mailing list <git@vger.kernel.org>
Subject: Re: 'git bisect run' not fully automatic when a merge base must be tested
Date: Sun, 24 Mar 2024 14:42:08 -0700 [thread overview]
Message-ID: <xmqq34sfqpcf.fsf@gitster.g> (raw)
In-Reply-To: <CAP8UFD2dNix6OMzCR5Ao8YLD-OVbcOfZOP90G7-QRx=OtRAoYw@mail.gmail.com> (Christian Couder's message of "Sun, 24 Mar 2024 18:57:48 +0100")
Christian Couder <christian.couder@gmail.com> writes:
> I think the merge bases should only be checked at the beginning of a
> bisection. So it is strange that it happened so late after it was
> started.
Using cherry-pick to alter the shape of the history being bisected
may confuse the algorithm to find the next step to test. But if it
is not "confused" but "due to dynamic expansion of the search space,
we ended up in a forked history that requires a merge-base test"
that is a legitimate condition, then I tend to agree with Philippe
that it should be automatically tested during "bisect run".
prev parent reply other threads:[~2024-03-24 21:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-24 16:57 'git bisect run' not fully automatic when a merge base must be tested Philippe Blain
2024-03-24 17:57 ` Christian Couder
2024-03-24 21:42 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq34sfqpcf.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=levraiphilippeblain@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).