From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org,
"brian m. carlson" <sandals@crustytoothpaste.net>,
rsbecker@nexbridge.com,
Angelo Dureghello <angelo@kernel-space.org>
Subject: Re: [PATCH] t5601: exercise clones with "includeIf.*.onbranch"
Date: Thu, 21 Mar 2024 19:11:09 -0700 [thread overview]
Message-ID: <xmqq34sj583m.fsf@gitster.g> (raw)
In-Reply-To: <ZfzmdcBT5MUqoxrk@tanuki> (Patrick Steinhardt's message of "Fri, 22 Mar 2024 03:01:25 +0100")
Patrick Steinhardt <ps@pks.im> writes:
> With Git v2.44 this behaviour did indeed change, and arguably for the
> better. This is because we now pre-init "HEAD" to "refs/heads/.invalid"
> instead of using the default branch name. Thus, we do not match "master"
> anymore, which is likely the correct thing to do.
;-)
> Thus the current version of my test that simply asserts that this does
> something successfully instead of crashing. In my opinion, we need to
> put more thought into how this is supposed to work before adding more
> tests.
OK. That is a sensible position to take.
Thanks.
next prev parent reply other threads:[~2024-03-22 2:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 19:25 [BUG] cannot git clone with includeif onbranch Angelo Dureghello
2024-03-08 20:10 ` brian m. carlson
2024-03-08 20:27 ` Angelo Dureghello
2024-03-08 21:20 ` rsbecker
2024-03-11 23:30 ` Patrick Steinhardt
2024-03-12 12:35 ` [PATCH] t5601: exercise clones with "includeIf.*.onbranch" Patrick Steinhardt
2024-03-12 20:38 ` Junio C Hamano
2024-03-22 2:01 ` Patrick Steinhardt
2024-03-22 2:11 ` Junio C Hamano [this message]
2024-03-22 2:15 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq34sj583m.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=angelo@kernel-space.org \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
--cc=rsbecker@nexbridge.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).