From: Junio C Hamano <gitster@pobox.com>
To: Naomi Ibe <naomi.ibeh69@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/1] [OUTREACHY] Fixed add.c file to conform to guidelines when using die() listed in issue #635
Date: Tue, 10 Oct 2023 15:24:30 -0700 [thread overview]
Message-ID: <xmqq34yiqfoh.fsf@gitster.g> (raw)
In-Reply-To: <CACS=G2yUGGJwD05KOFZK+AV3TSNDvDEfC=pFRsLwKX_-dgt+gA@mail.gmail.com> (Naomi Ibe's message of "Tue, 10 Oct 2023 16:19:46 +0100")
Naomi Ibe <naomi.ibeh69@gmail.com> writes:
> Thank you very much! I'd definitely make those changes on my next patch.
[administrivia] do not top post.
> Should I begin work on version 2 or should I still wait for additional
> input on the version 1?
There is no "rule", but based on observations on how people behave,
e.g.
* for a small patch like this that can be given a good review in 10
minutes or so, those who do not do so within the first 3 days
will probably not do so.
* once a reasonably thorough review is given, those who haven't
responded to the patch and do not have much else to say are
unlikely to respond.
* on the other hand, after such a review is given, those who do not
agree with the review tend to respond rather quickly, to get
their voice in before it becomes too late.
I would say it would be good to start working on it right away and
use a couple of days reviewing it yourself before posting it.
next prev parent reply other threads:[~2023-10-10 22:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 1:15 [PATCH 1/1] [OUTREACHY] Fixed add.c file to conform to guidelines when using die() listed in issue #635 Naomi Ibe
2023-10-09 18:49 ` Junio C Hamano
2023-10-10 15:19 ` Naomi Ibe
2023-10-10 19:22 ` Christian Couder
2023-10-10 22:24 ` Junio C Hamano [this message]
2023-10-11 5:50 ` Naomi Ibe
2023-10-11 6:17 ` Dragan Simic
-- strict thread matches above, loose matches on Subject: below --
2023-10-09 1:16 Naomi Ibe
2023-10-09 7:27 ` Christian Couder
2023-10-09 7:57 ` Naomi Ibe
2023-10-09 8:22 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq34yiqfoh.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=naomi.ibeh69@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).