From: Junio C Hamano <gitster@pobox.com>
To: Eric Wong <e@80x24.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] avoid SHA-1 functions deprecated in OpenSSL 3+
Date: Tue, 01 Aug 2023 13:17:51 -0700 [thread overview]
Message-ID: <xmqq3512bjps.fsf@gitster.g> (raw)
In-Reply-To: <20230801195325.M746978@dcvr> (Eric Wong's message of "Tue, 1 Aug 2023 19:53:25 +0000")
Eric Wong <e@80x24.org> writes:
> I just copied the existing SHA256 stuff and mostly did a
> s/SHA256/SHA1/ in patch 2/2. I'm not sure why
> SHA256_NEEDS_CLONE_HELPER was needed, either, but I decided
> to keep the SHA1 and SHA256 code as similar as possible for
> consistency.
>
> We could probably drop both *_NEEDS_CLONE_HELPER macros,
> but that's a separate patch.
Fair enough. Thanks.
prev parent reply other threads:[~2023-08-01 20:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 2:54 [PATCH 0/2] avoid functions deprecated in OpenSSL 3+ Eric Wong
2023-08-01 2:54 ` [PATCH 1/2] sha256: " Eric Wong
2023-08-01 2:54 ` [PATCH 2/2] avoid SHA-1 " Eric Wong
2023-08-01 16:03 ` Junio C Hamano
2023-08-01 19:53 ` Eric Wong
2023-08-01 20:17 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq3512bjps.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).