From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Glen Choo <chooglen@google.com>, git@vger.kernel.org
Subject: Re: [PATCH] http: handle both "h2" and "h2h3" in curl info lines
Date: Sat, 17 Jun 2023 02:13:03 -0700 [thread overview]
Message-ID: <xmqq352qsb8g.fsf@gitster.g> (raw)
In-Reply-To: <20230617080705.GA2151825@coredump.intra.peff.net> (Jeff King's message of "Sat, 17 Jun 2023 04:07:05 -0400")
Jeff King <peff@peff.net> writes:
> On Sat, Jun 17, 2023 at 01:15:59AM -0400, Jeff King wrote:
>
>> Ah, I see. It looks like it depends on which version of curl is using.
>> Perhaps the macOS image in CI has been updated (or maybe the new version
>> just became available via brew or something). I was able to replicate on
>> my Linux system by building and linking against curl 8.1.0, and the
>> patch above (modulo some missing parentheses) fixes it.
>
> Oh, and just to solve this one remaining riddle: it was indeed a change
> in the images. If you click through to the log of the failing osx-clang
> job in your first link, then expand "Set up job" and then "Runner
> image", you'll see that it was using:
>
> https://github.com/actions/runner-images/blob/macOS-12/20230612.1/images/macos/macos-12-Readme.md
>
> which mentions curl 8.1.2. Whereas on your other link (where the jobs
> did not fail), it was last month's:
>
> https://github.com/actions/runner-images/blob/macOS-12/20230516.1/images/macos/macos-12-Readme.md
>
> which has curl 8.0.1. So presumably every CI run from here forward will
> fail unless we patch it.
Wow, you are (as usual) thorough. Thanks for digging.
next prev parent reply other threads:[~2023-06-17 9:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 22:05 Is MacOS CI flaky? Glen Choo
2023-06-16 23:44 ` Junio C Hamano
2023-06-17 4:42 ` Jeff King
2023-06-17 5:15 ` [PATCH] http: handle both "h2" and "h2h3" in curl info lines Jeff King
2023-06-17 5:31 ` Jeff King
2023-06-17 5:45 ` Jeff King
2023-06-17 8:07 ` Jeff King
2023-06-17 9:13 ` Junio C Hamano [this message]
2023-06-20 20:31 ` Glen Choo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq352qsb8g.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=chooglen@google.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).