* [PATCH] config: tell the user that we expect an ASCII character
@ 2023-03-27 19:43 Kristoffer Haugsbakk
2023-03-27 20:09 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Kristoffer Haugsbakk @ 2023-03-27 19:43 UTC (permalink / raw)
To: git; +Cc: Kristoffer Haugsbakk
Commit 50b54fd72a (config: be strict on core.commentChar, 2014-05-17)
notes that “multi-byte character encoding could also be misinterpreted”,
and indeed a multi-byte codepoint (non-ASCII) is not accepted as a valid
`core.commentChar`.
Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name>
---
config.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/config.c b/config.c
index 00090a32fc..ae68c0f736 100644
--- a/config.c
+++ b/config.c
@@ -1683,7 +1683,7 @@ static int git_default_core_config(const char *var, const char *value, void *cb)
comment_line_char = value[0];
auto_comment_line_char = 0;
} else
- return error(_("core.commentChar should only be one character"));
+ return error(_("core.commentChar should only be one ASCII character"));
return 0;
}
--
2.40.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-27 20:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-27 19:43 [PATCH] config: tell the user that we expect an ASCII character Kristoffer Haugsbakk
2023-03-27 20:09 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).