git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Todd Zullinger <tmz@pobox.com>, git@vger.kernel.org
Subject: Re: t5559 breaks with apache 2.4.55
Date: Thu, 09 Feb 2023 13:45:10 -0800	[thread overview]
Message-ID: <xmqq357ems2h.fsf@gitster.g> (raw)
In-Reply-To: <Y9YTsF4a8lL7uHm+@coredump.intra.peff.net> (Jeff King's message of "Sun, 29 Jan 2023 01:35:28 -0500")

Jeff King <peff@peff.net> writes:

> ...
> But that does at least give me more confidence that the bug is in
> mod_http2, and isn't, say, some intentional behavior change there that
> happens to trigger a bug in curl.
>
> I opened an issue here: https://github.com/icing/mod_h2/issues/243
>
> So we'll see if that helps.

Thanks.  I've seen that the above issue may have redirected the
investigation to cURL, and over time, I expect taht this will start
to trigger in more environments (as Apache 2.4.55 and mod_h2 2.0.10
propagates) before it fixes itself (as fixed versions of these
things we use in our tests percolates down).

In the meantime, perhaps we should punt with a patch like this?


------------ >8 ------------
Subject: [PATCH] t5559: skip a known-to-be-broken test

t5559 runs the same set of tests as t5551 under HTTP/2 but one of
them started failing with Apache 2.4.55 and mod_h2 2.0.10 (but not
with HTTP/1.1).  Newer mod_h2 is known to have fixed the issue.

In the meantime, skip the test.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 t/t5551-http-fetch-smart.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git c/t/t5551-http-fetch-smart.sh w/t/t5551-http-fetch-smart.sh
index bc0719a4fc..52159e8b6f 100755
--- c/t/t5551-http-fetch-smart.sh
+++ w/t/t5551-http-fetch-smart.sh
@@ -350,7 +350,8 @@ test_expect_success CMDLINE_LIMIT \
 	)
 '
 
-test_expect_success 'large fetch-pack requests can be sent using chunked encoding' '
+# https://github.com/icing/mod_h2/issues/243
+test_expect_success !HTTP2 'large fetch-pack requests can be sent using chunked encoding' '
 	GIT_TRACE_CURL=true git -c http.postbuffer=65536 \
 		clone --bare "$HTTPD_URL/smart/repo.git" split.git 2>err &&
 	{


  reply	other threads:[~2023-02-09 21:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-22  8:00 t5559 breaks with apache 2.4.55 Jeff King
2023-01-22 16:33 ` Todd Zullinger
2023-01-26 11:39   ` Jeff King
2023-01-29  6:35     ` Jeff King
2023-02-09 21:45       ` Junio C Hamano [this message]
2023-02-11  2:20         ` Jeff King
2023-02-11  2:34           ` Junio C Hamano
2023-02-11  3:00             ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq357ems2h.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=tmz@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).