From: Junio C Hamano <gitster@pobox.com>
To: "Rose via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Johannes Sixt <j6t@kdbg.org>,
Seija Kijin <doremylover123@gmail.com>
Subject: Re: [PATCH v4] compat/winansi: check for errors of CreateThread() correctly
Date: Wed, 01 Feb 2023 14:37:49 -0800 [thread overview]
Message-ID: <xmqq357pyptu.fsf@gitster.g> (raw)
In-Reply-To: <pull.1445.v4.git.git.1675290034144.gitgitgadget@gmail.com> (Rose via GitGitGadget's message of "Wed, 01 Feb 2023 22:20:33 +0000")
"Rose via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Seija Kijin <doremylover123@gmail.com>
>
> The return value for failed thread creation is NULL,
> not INVALID_HANDLE_VALUE, unlike other Windows API functions.
>
> Signed-off-by: Seija Kijin <doremylover123@gmail.com>
> ---
Thanks. Will queue with the Ack by j6t given earlier.
next prev parent reply other threads:[~2023-02-01 22:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 14:49 [PATCH] win32: check for NULL when creating thread Rose via GitGitGadget
2023-01-31 14:53 ` [PATCH v2] win32: check for NULL after " Rose via GitGitGadget
2023-02-01 14:40 ` [PATCH v3] " Rose via GitGitGadget
2023-02-01 21:51 ` Johannes Sixt
2023-02-01 22:20 ` [PATCH v4] compat/winansi: check for errors of CreateThread() correctly Rose via GitGitGadget
2023-02-01 22:37 ` Junio C Hamano [this message]
2023-02-01 22:39 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq357pyptu.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=doremylover123@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).