git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Glen Choo <chooglen@google.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	git@vger.kernel.org
Subject: Re: sudmodule.<name>.recurse ignored
Date: Fri, 07 Oct 2022 14:13:12 -0700	[thread overview]
Message-ID: <xmqq35bze3rr.fsf@gitster.g> (raw)
In-Reply-To: <kl6lpmf3wdk6.fsf@chooglen-macbookpro.roam.corp.google.com> (Glen Choo's message of "Fri, 07 Oct 2022 14:04:25 -0700")

Glen Choo <chooglen@google.com> writes:

> - where to get the submodule from during a fetch/clone, e.g.
>   `submodule.<name>.url`, `submodule.<name>.branch`
> - information needed for submodules to work correctly, e.g.
>   `submodule.<name>.path`
> - default config that gets populated in .git/config via `git submodule
>   init`, e.g. `submodule.<name>.update`,
>   `submodule.<name>.fetchRecurseSubmodules`
>
> With respect to config, the general stance is that .gitmodules is meant
> to provide defaults for .git/config and _not_ to be read directly (see
> Ævar's answer).

I think that is a sensible way to think about this.

It is more like "suggestion made by the upstream", to be taken after
examining it, just like you should type "make" after examining the
Makefile.  At least enough to trust its contents ;-)

> There are some very limited cases where config is read
> directly from .gitmodules, but that approach is very frowned upon and
> it's unlikely that we'll add more of them in the future.

Yup, we should be careful and see if we can get rid of existing
uses.

Thanks.

  reply	other threads:[~2022-10-07 21:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-07 10:10 sudmodule.<name>.recurse ignored Michael S. Tsirkin
2022-10-07 11:09 ` Ævar Arnfjörð Bjarmason
2022-10-07 12:56   ` Michael S. Tsirkin
2022-10-07 21:04     ` Glen Choo
2022-10-07 21:13       ` Junio C Hamano [this message]
2022-10-11 22:34         ` Michael S. Tsirkin
2022-10-12 16:56           ` Glen Choo
2022-10-12 21:49             ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq35bze3rr.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=chooglen@google.com \
    --cc=git@vger.kernel.org \
    --cc=mst@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).