From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org,
"brian m . carlson" <sandals@crustytoothpaste.net>,
rsbecker@nexbridge.com
Subject: Re: [RFC PATCH 4/4] .clang-format: don't indent "goto" labels
Date: Mon, 11 Jul 2022 14:04:15 -0700 [thread overview]
Message-ID: <xmqq35f7nyy8.fsf@gitster.g> (raw)
In-Reply-To: <RFC-patch-4.4-e3a95c62bda-20220711T110019Z-avarab@gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Mon, 11 Jul 2022 13:37:28 +0200")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> This change is a slightly mixed bag, we have a lot of "goto" labels
> that are indented by exactly one space.
>
> Before & after this change running "make style-all-diff-apply" will
> yield:
>
> 509 files changed, 13042 insertions(+), 12745 deletions(-)
> 510 files changed, 13039 insertions(+), 12742 deletions(-)
More files changed with fewer changes, or the above is not
copy-and-paste but typed in?
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
> .clang-format | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/.clang-format b/.clang-format
> index 5a106d959be..56d7e8f9def 100644
> --- a/.clang-format
> +++ b/.clang-format
> @@ -148,6 +148,9 @@ SpacesInSquareBrackets: false
> # clang-format 12.
> BitFieldColonSpacing: None
>
> +# Do not indent "goto" labels, they should be flushed left.
> +IndentGotoLabels: false
> +
> # Insert a space after '{' and before '}' in struct initializers
> Cpp11BracedListStyle: false
next prev parent reply other threads:[~2022-07-11 21:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-10 21:50 Automatic code formatting brian m. carlson
2022-07-10 22:08 ` Junio C Hamano
2022-07-10 22:13 ` rsbecker
2022-07-11 0:58 ` brian m. carlson
2022-07-11 1:28 ` rsbecker
2022-07-11 16:53 ` Elijah Newren
2022-07-11 20:15 ` Ævar Arnfjörð Bjarmason
2022-07-11 21:19 ` Elijah Newren
2022-07-11 11:37 ` [RFC PATCH 0/4] make headway towards a clean "clang-format" Ævar Arnfjörð Bjarmason
2022-07-11 11:37 ` [RFC PATCH 1/4] Makefile: add a style-all targets for .clang-format testing Ævar Arnfjörð Bjarmason
2022-07-11 11:37 ` [RFC PATCH 2/4] .clang-format: Add a BitFieldColonSpacing=None rule Ævar Arnfjörð Bjarmason
2022-07-11 22:42 ` brian m. carlson
2022-07-11 22:52 ` Junio C Hamano
2022-07-12 6:56 ` Ævar Arnfjörð Bjarmason
2022-07-11 11:37 ` [RFC PATCH 3/4] .clang-format: do not enforce a ColumnLimit Ævar Arnfjörð Bjarmason
2022-07-11 21:37 ` Junio C Hamano
2022-07-12 7:03 ` Ævar Arnfjörð Bjarmason
2022-07-11 22:39 ` brian m. carlson
2022-07-11 22:46 ` Junio C Hamano
2022-07-11 23:05 ` Eric Sunshine
2022-07-11 23:30 ` Junio C Hamano
2022-07-11 11:37 ` [RFC PATCH 4/4] .clang-format: don't indent "goto" labels Ævar Arnfjörð Bjarmason
2022-07-11 21:04 ` Junio C Hamano [this message]
2022-07-12 6:55 ` Ævar Arnfjörð Bjarmason
2022-07-11 13:17 ` Automatic code formatting Phillip Wood
2022-07-11 13:21 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq35f7nyy8.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=rsbecker@nexbridge.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).