From: Junio C Hamano <gitster@pobox.com>
To: "Jaydeep Das via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Eric Sunshine <sunshine@sunshineco.com>,
Jaydeep Das <jaydeepjd.8914@gmail.com>
Subject: Re: [PATCH v4] gpg-interface: add function for converting trust level to string
Date: Sun, 10 Jul 2022 22:12:21 -0700 [thread overview]
Message-ID: <xmqq35f8p70q.fsf@gitster.g> (raw)
In-Reply-To: <pull.1281.v4.git.1657515650587.gitgitgadget@gmail.com> (Jaydeep Das via GitGitGadget's message of "Mon, 11 Jul 2022 05:00:50 +0000")
"Jaydeep Das via GitGitGadget" <gitgitgadget@gmail.com> writes:
> @@ pretty.c: static size_t format_commit_one(struct strbuf *sb, /* in UTF-8 */
> - strbuf_addstr(sb, "ultimate");
> - break;
> - }
> -+ sig_str = gpg_trust_level_to_str(c->signature_check.trust_level);
> -+ if (sig_str)
> -+ strbuf_addstr(sb, sig_str);
> -+ free(sig_str);
> ++ strbuf_addstr(sb, gpg_trust_level_to_str(c->signature_check.trust_level));
This part of the range-diff is the most pleasant to see.
Will queue. Thanks.
prev parent reply other threads:[~2022-07-11 5:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 13:57 [PATCH] gpg-interface: add function for converting trust level to string Jaydeep Das via GitGitGadget
2022-07-07 18:18 ` Junio C Hamano
2022-07-08 11:24 ` [PATCH v2] " Jaydeep Das via GitGitGadget
2022-07-09 0:58 ` Eric Sunshine
2022-07-09 3:51 ` jaydeepjd.8914
2022-07-09 20:52 ` Junio C Hamano
2022-07-10 5:44 ` Eric Sunshine
2022-07-10 5:48 ` Junio C Hamano
2022-07-10 6:21 ` Eric Sunshine
2022-07-11 3:51 ` Jaydeep Das
2022-07-09 4:43 ` [PATCH v3] " Jaydeep Das via GitGitGadget
2022-07-11 5:00 ` [PATCH v4] " Jaydeep Das via GitGitGadget
2022-07-11 5:12 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq35f8p70q.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=jaydeepjd.8914@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).