From: Junio C Hamano <gitster@pobox.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH v2 try2 3/4] completion: bash: fix for multiple dash commands
Date: Tue, 08 Jun 2021 14:15:05 +0900 [thread overview]
Message-ID: <xmqq35ttq6na.fsf@gitster.g> (raw)
In-Reply-To: 60be6f7fa4435_db80d208f2@natae.notmuch
Felipe Contreras <felipe.contreras@gmail.com> writes:
> SZEDER Gábor wrote:
>> On Sun, Jun 06, 2021 at 01:47:25PM -0500, Felipe Contreras wrote:
>> > Otherwise commands like 'for-each-ref' are not completed.
>>
>> I think you meant that options of commands like 'for-each-ref' are not
>> completed.
>> ...
> Yes, I meant commands like 'for-each-ref' are not completed correctly...
> by __gitcomp_builtin. Which in practical tearms means what you just
> described above.
I couldn't exactly tell if that's a roundabout way to say "yes,
yours is better and I'll use it in an update, thanks". I'll assume
that is the case and will mark the topic as expecting the final
update (as it seemed that all the other patches in the series were
received favourably).
Or was it meant as "no, the version you commented on was already
correct (if you squint your eyes)"?
Thanks.
next prev parent reply other threads:[~2021-06-08 5:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-06 18:47 [PATCH v2 try2 0/4] completion: bash: a bunch of fixes Felipe Contreras
2021-06-06 18:47 ` [PATCH v2 try2 1/4] completion: bash: fix prefix detection in branch.* Felipe Contreras
2021-06-06 18:47 ` [PATCH v2 try2 2/4] completion: bash: fix for suboptions with value Felipe Contreras
2021-06-06 18:47 ` [PATCH v2 try2 3/4] completion: bash: fix for multiple dash commands Felipe Contreras
2021-06-07 19:00 ` SZEDER Gábor
2021-06-07 19:11 ` Felipe Contreras
2021-06-08 5:15 ` Junio C Hamano [this message]
2021-06-08 5:49 ` Felipe Contreras
2021-06-06 18:47 ` [PATCH v2 try2 4/4] completion: bash: add correct suffix in variables Felipe Contreras
2021-06-07 0:46 ` [PATCH v2 try2 0/4] completion: bash: a bunch of fixes David Aguilar
2021-06-07 1:08 ` Junio C Hamano
2021-06-08 6:00 ` [PATCH v3 " Felipe Contreras
2021-06-08 6:00 ` [PATCH v3 1/4] completion: bash: fix prefix detection in branch.* Felipe Contreras
2021-06-08 6:00 ` [PATCH v3 2/4] completion: bash: fix for suboptions with value Felipe Contreras
2021-06-08 6:00 ` [PATCH v3 3/4] completion: bash: fix for multiple dash commands Felipe Contreras
2021-06-08 6:00 ` [PATCH v3 4/4] completion: bash: add correct suffix in variables Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq35ttq6na.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).