From: Junio C Hamano <gitster@pobox.com>
To: Alex Henrie <alexhenrie24@gmail.com>
Cc: Elijah Newren <newren@gmail.com>,
Git Mailing List <git@vger.kernel.org>,
Robert Dailey <rcdailey.lists@gmail.com>,
rsbecker@nexbridge.com, Konstantin Tokarev <annulen@yandex.ru>,
Theodore Tso <tytso@mit.edu>
Subject: Re: [PATCH v3] pull: warn if the user didn't say whether to rebase or to merge
Date: Mon, 02 Mar 2020 13:51:08 -0800 [thread overview]
Message-ID: <xmqq36aqbf3n.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CAMMLpeS2Fq3Nj2QjvNT6i_+ceDHW-pUqTRUhmARWen-jWQfsJg@mail.gmail.com> (Alex Henrie's message of "Sat, 29 Feb 2020 20:27:56 -0700")
Alex Henrie <alexhenrie24@gmail.com> writes:
> On Sat, Feb 29, 2020 at 4:31 PM Elijah Newren <newren@gmail.com> wrote:
>>
> ... We also want the user to understand that they
> only have to set pull.rebase or pull.ff once, whereas a command-line
> flag applies only to the current pull.
I do not think the phrasing you used has the intended effect.
You can replace "git config" with "git config --global" to set a
default preference for all repositories. You can pass --rebase,
--no-rebase, or --ff-only on the command line to override the
configured default per invocation.
may be more appropriate. "You can use it, but you need to do so
every time you pull" drives readers away by placing stress on how
cumbersome it *can* become, but in practice, nobody would use the
same command line option every time anyway.
In contrast, explaining the command line option as a useful
mechanism for one-shot override, and the configuration variable as a
useful mechanism for set-and-forget convenience feature, would teach
readers in what situation use of the configuration variables and the
command line options shine the best.
Thanks.
next prev parent reply other threads:[~2020-03-02 21:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-29 21:22 [PATCH v3] pull: warn if the user didn't say whether to rebase or to merge Alex Henrie
2020-02-29 23:30 ` Elijah Newren
2020-03-01 3:27 ` Alex Henrie
2020-03-02 21:51 ` Junio C Hamano [this message]
2020-03-02 22:37 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq36aqbf3n.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=alexhenrie24@gmail.com \
--cc=annulen@yandex.ru \
--cc=git@vger.kernel.org \
--cc=newren@gmail.com \
--cc=rcdailey.lists@gmail.com \
--cc=rsbecker@nexbridge.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).