From: Junio C Hamano <gitster@pobox.com>
To: Slavica Djukic <slavicadj.ip2018@gmail.com>
Cc: Johannes.Schindelin@gmx.de, git@vger.kernel.org, slawica92@hotmail.com
Subject: Re: [PATCH v2 1/2] [Outreachy] t3903-stash: test without configured user.name and user.email
Date: Sun, 18 Nov 2018 15:28:34 +0900 [thread overview]
Message-ID: <xmqq36ryhpbh.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <a75dcea8-797d-9c9b-3453-2de2a4d983dd@gmail.com> (Slavica Djukic's message of "Sat, 17 Nov 2018 19:47:53 +0100")
Slavica Djukic <slavicadj.ip2018@gmail.com> writes:
>> Yes, but for that you'd need to be checking the resulting commit
>> object that represents the stash entry. It should be created under
>> the substitute identity.
> Would it be correct to check it like this:
>
> git reset &&
> >1 &&
> git add 1 &&
> echo "$GIT_AUTHOR_NAME <$GIT_AUTHOR_EMAIL>" >expect &&
> git stash &&
> git show -s --format="%an <%ae>" refs/stash >actual &&
> test_cmp expect actual
So, you create a stash, and grab %an and %ae out of the resulting
commit object and store them in actual, and then compare. Makes
sense.
next prev parent reply other threads:[~2018-11-18 6:31 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 16:29 [PATCH 1/3] [Outreachy] t3903-stash: test without configured user name Slavica
2018-10-23 18:52 ` Christian Couder
2018-10-24 13:56 ` Slavica
2018-10-25 4:44 ` Junio C Hamano
2018-10-23 19:19 ` Eric Sunshine
2018-10-24 2:48 ` Junio C Hamano
2018-10-24 7:39 ` Johannes Schindelin
2018-10-24 9:58 ` Junio C Hamano
2018-10-24 15:18 ` Johannes Schindelin
2018-10-25 4:17 ` Junio C Hamano
2018-10-24 20:01 ` [PATCH v2 " Slavica Djukic
2018-10-24 20:05 ` Slavica Djukic
2018-10-24 20:25 ` Eric Sunshine
2018-10-25 4:48 ` Junio C Hamano
2018-10-25 19:13 ` [PATCH v3 " Slavica Djukic
2018-10-25 19:20 ` Slavica Djukic
2018-10-26 1:13 ` Junio C Hamano
2018-10-30 13:04 ` Slavica Djukic
2018-11-01 11:55 ` [PATCH 0/3] [Outreachy] make stash work if user.name and user.email are not configured Slavica Djukic
2018-11-01 11:58 ` [PATCH 1/3][Outreachy] t3903-stash: test without configured user.name and user.email Slavica Djukic
2018-11-01 14:53 ` Christian Couder
2018-11-02 4:59 ` [PATCH 2+3/3] stash: tolerate missing user identity Junio C Hamano
2018-11-01 12:00 ` [PATCH 2/3] [Outreachy] ident: introduce set_fallback_ident() function Slavica Djukic
2018-11-02 3:01 ` Junio C Hamano
2018-11-02 4:41 ` Junio C Hamano
2018-11-02 5:22 ` Junio C Hamano
2018-11-01 12:02 ` [PATCH 3/3] [Outreachy] stash: use " Slavica Djukic
2018-11-14 22:12 ` [PATCH v2 0/2] [Outreachy] make stash work if user.name and user.email are not configured Slavica Djukic
2018-11-14 22:25 ` [PATCH v2 1/2] [Outreachy] t3903-stash: test without configured user.name and user.email Slavica Djukic
2018-11-15 12:37 ` Johannes Schindelin
2018-11-16 5:55 ` Junio C Hamano
2018-11-16 6:26 ` Junio C Hamano
2018-11-16 6:32 ` Junio C Hamano
2018-11-16 8:28 ` Slavica Djukic
2018-11-16 10:12 ` Junio C Hamano
2018-11-17 18:47 ` Slavica Djukic
2018-11-18 6:28 ` Junio C Hamano [this message]
2018-11-14 22:28 ` [PATCH v2 2/2] [Outreachy] stash: tolerate missing user identity Slavica Djukic
2018-11-16 5:35 ` Junio C Hamano
2018-11-18 13:29 ` [PATCH 0/1 v3] make stash work if user.name and user.email are not configured Slavica Djukic
2018-11-18 13:44 ` [PATCH 1/1 v3] stash: tolerate missing user identity Slavica Djukic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq36ryhpbh.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=slavicadj.ip2018@gmail.com \
--cc=slawica92@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).