git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Update hard-coded header dependencies
Date: Sun, 10 Aug 2014 16:31:06 -0700	[thread overview]
Message-ID: <xmqq38d39b2d.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140808215825.GH12427@google.com> (Jonathan Nieder's message of "Fri, 8 Aug 2014 14:58:26 -0700")

Jonathan Nieder <jrnieder@gmail.com> writes:

> The fall-back rules used when compilers don't support the -MMD switch
> to generate makefile rules based on #includes have been out of date
> since v1.7.12.1~22^2~8 (move git_version_string into version.c,
> 2012-06-02).
>
> Checked with 'make CHECK_HEADER_DEPENDENCIES=yes'.
>
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
> ---
> Maybe it's worth switching to plain
>
> 	LIB_H += $(wildcard *.h)
>
> ?  People using ancient compilers that never change headers wouldn't
> be hurt, people using modern compilers that do change headers also
> wouldn't be hurt, and we could stop pretending to maintain an
> up-to-date list.

I agree that it is very tempting to declare that we do not manually
"maintain" the dependency list and force people without -MMD to
recompile whenever any unrelated header changes.  Especially that
this patch only works on the 'master' branch and upwards, and does
not even work on 'maint', let alone 1.9 or 1.8.5 maintenance tracks.

Let's consider the merit of that approach after 2.1 is out.  Thanks.

  parent reply	other threads:[~2014-08-10 23:31 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-08 21:58 [PATCH] Update hard-coded header dependencies Jonathan Nieder
2014-08-10 19:48 ` Jeff King
2014-08-21  8:24   ` Jeff King
2014-08-21  8:29     ` [PATCH 1/2] Makefile: use "find" to determine static " Jeff King
2014-08-21 14:48       ` Jonathan Nieder
2014-08-22  4:12         ` Jeff King
2014-08-22  4:27           ` [PATCH v2 0/3] dropping manually-maintained LIB_H Jeff King
2014-08-22  4:32             ` [PATCH 1/3] i18n: treat "make pot" as an explicitly-invoked target Jeff King
2014-08-22  4:33             ` [PATCH 2/3] Makefile: use `find` to determine static header dependencies Jeff King
2014-08-25 19:30               ` Junio C Hamano
2014-08-25 19:33                 ` Jeff King
2014-08-25 19:46               ` Jonathan Nieder
2014-08-25 20:00                 ` Jeff King
2014-08-25 20:09                   ` Jeff King
2014-08-25 20:45                   ` Jonathan Nieder
2014-08-25 21:03                     ` Junio C Hamano
2014-08-25 21:27                       ` Jonathan Nieder
2014-08-25 22:08                         ` Junio C Hamano
2014-08-26 12:34                           ` Jeff King
2014-08-26 16:54                             ` Junio C Hamano
2014-08-26 17:29                               ` Jeff King
2014-08-26 19:40                                 ` Junio C Hamano
2014-08-22  4:33             ` [PATCH 3/3] Makefile: drop CHECK_HEADER_DEPENDENCIES code Jeff King
2014-08-23 11:06         ` [PATCH 1/2] Makefile: use "find" to determine static header dependencies Jiang Xin
2014-08-21  8:31     ` [PATCH 2/2] Makefile: drop CHECK_HEADER_DEPENDENCIES code Jeff King
2014-08-10 23:31 ` Junio C Hamano [this message]
2014-08-10 23:39   ` [PATCH] Update hard-coded header dependencies Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq38d39b2d.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).