From: Junio C Hamano <gitster@pobox.com>
To: Heiko Voigt <hvoigt@hvoigt.net>
Cc: git@vger.kernel.org, Jens Lehmann <jens.lehmann@web.de>,
Jonathan Nieder <jrnieder@gmail.com>, Jeff King <peff@peff.net>
Subject: Re: [PATCH 2/5] implement submodule config cache for lookup of submodule names
Date: Thu, 12 Jun 2014 14:58:20 -0700 [thread overview]
Message-ID: <xmqq38f96b9f.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140605060750.GC23874@sandbox-ub> (Heiko Voigt's message of "Thu, 5 Jun 2014 08:07:50 +0200")
Heiko Voigt <hvoigt@hvoigt.net> writes:
> ...
> +static int is_cache_init = 0;
Please don't initialise variables in the .bss to zero by hand.
> + ...
> + warning("%s:.gitmodules, multiple configurations found for "
> + "submodule.%s.%s. Skipping second one!",
> + commit_string, name, option);
> +}
> + ...
> + if (strcmp(value, "untracked") && strcmp(value, "dirty") &&
> + strcmp(value, "all") && strcmp(value, "none")) {
> + warning("Invalid parameter \"%s\" for config option "
> + "\"submodule.%s.ignore\"", value, var);
> + goto release_return;
> + }
These two look inconsistent in different ways. I think we typically
quote the names like so:
warning("I have trouble with variable '%s' somehow", var);
next prev parent reply other threads:[~2014-06-12 21:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 6:04 [PATCH 0/5] submodule config lookup API Heiko Voigt
2014-06-05 6:06 ` [PATCH 1/5] hashmap: add enum for hashmap free_entries option Heiko Voigt
2014-06-06 17:52 ` Karsten Blees
2014-06-10 10:17 ` Heiko Voigt
2014-06-11 9:12 ` Karsten Blees
2014-06-12 19:12 ` Junio C Hamano
2014-06-17 8:30 ` Karsten Blees
2014-06-17 19:04 ` Heiko Voigt
2014-06-17 22:19 ` Junio C Hamano
2014-06-05 6:07 ` [PATCH 2/5] implement submodule config cache for lookup of submodule names Heiko Voigt
2014-06-05 17:46 ` W. Trevor King
2014-06-06 5:20 ` Heiko Voigt
2014-06-08 9:04 ` Eric Sunshine
2014-06-10 10:19 ` Heiko Voigt
2014-06-12 21:58 ` Junio C Hamano [this message]
2014-06-13 22:37 ` Heiko Voigt
2014-06-05 6:08 ` [PATCH 3/5] extract functions for submodule config set and lookup Heiko Voigt
2014-06-05 6:09 ` [PATCH 4/5] use new config API for worktree configurations of submodules Heiko Voigt
2014-06-05 6:09 ` [PATCH 5/5] do not die on error of parsing fetchrecursesubmodules option Heiko Voigt
2014-06-12 21:59 ` [PATCH 0/5] submodule config lookup API Junio C Hamano
2014-06-13 22:41 ` Heiko Voigt
2014-06-16 17:58 ` Junio C Hamano
2014-06-17 19:00 ` Heiko Voigt
2014-06-12 22:04 ` Junio C Hamano
2014-06-13 7:13 ` Jens Lehmann
2014-06-13 17:50 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq38f96b9f.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=hvoigt@hvoigt.net \
--cc=jens.lehmann@web.de \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).