From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Antoni Borowski <antekborowski11@gmail.com>,
git@vger.kernel.org, Josh Poimboeuf <jpoimboe@kernel.org>
Subject: Re: [Microproject] describe: pluralize tag/commit count messages
Date: Wed, 14 Oct 2026 10:36:26 -0700 [thread overview]
Message-ID: <xmqq4ieotc9x.fsf@gitster.g> (raw)
In-Reply-To: <20261014092923.GA1344504@coredump.intra.peff.net> (Jeff King's message of "Wed, 14 Oct 2026 05:29:23 -0400")
Jeff King <peff@peff.net> writes:
> OK. The patch looks obviously correct, though I do find it a little
> funny that we bother to translate these debug messages in the first
> place.
>
> I wonder if there is even really value in keeping "--debug" here at all.
> But that is a somewhat bigger change.
>
> The patch here seems OK to me in the meantime (and totally fine for a
> microproject).
Yeah, but a microproject that convincingly argues that output from
the "--debug" option should not even be translated and undoes _()
would make a much better case to see how a new person works well ;-).
prev parent reply other threads:[~2026-10-14 17:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 20:43 [Microproject] describe: pluralize tag/commit count messages Antoni Borowski
2026-10-14 9:29 ` Jeff King
2026-10-14 17:36 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4ieotc9x.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=antekborowski11@gmail.com \
--cc=git@vger.kernel.org \
--cc=jpoimboe@kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox