From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-b6-smtp.messagingengine.com (fhigh-b6-smtp.messagingengine.com [202.12.124.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAA6341DEE5 for ; Wed, 26 Aug 2026 15:24:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.157 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787757882; cv=none; b=Jx5RqMlu6XGJOOW/YK5HLrrlibFPihzfL92kY4J94PAldVIyonS5nLgJYMBxb2iE+nkeI9oAqj2cUJSxwIXNkLHx3FCfXgujDrbRcpX2K0GzxS2GZsathDsOqs5nfZfWlOe3Hbj2bN+3mBz066c0cAdWvsA9TPngOO9CPe4Vd8k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787757882; c=relaxed/simple; bh=rR7nQ5h/ucn1/5SdPSNNlkmAcGCE7kg+wEtcatYsodY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=NCedssOBe7cSfw/JG/SaVCDqdNnFSWGm92KUJgz1i30xq81I4c+TLWrgS7bOxmVF/eSKmVU+iFl/uQWERtfzDc2/qGo9WIqu6+ezxK2jJlJKJ+5wtzryzMA9CUD4/r64HZxHAUF46aLOS9dAdmq0CiH/lFJp9GdLwj4LbdyOZBE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com; spf=pass smtp.mailfrom=pobox.com; dkim=pass (2048-bit key) header.d=pobox.com header.i=@pobox.com header.b=NfRruQxX; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=VxNUTbFD; arc=none smtp.client-ip=202.12.124.157 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pobox.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pobox.com header.i=@pobox.com header.b="NfRruQxX"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="VxNUTbFD" Received: from phl-compute-12.internal (phl-compute-12.internal [10.202.2.52]) by mailfhigh.stl.internal (Postfix) with ESMTP id CBE2B7A011C; Wed, 26 Aug 2026 11:24:39 -0400 (EDT) Received: from phl-frontend-01 ([10.202.2.160]) by phl-compute-12.internal (MEProxy); Wed, 26 Aug 2026 11:24:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pobox.com; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1787757879; x=1787844279; bh=JdqlVpt7/p dzVutdn11mWFNzSbY/Ef8orM9GHM96CA8=; b=NfRruQxXbIs8sa59N2d+kgBQrF 2h8IMA8CO6zrAM2dbGJ6/TubWwVQJ6cGZpfTA0qNEP4dypH9hpH1UvQHpG6jKS/9 sXthq4uH5+/xw6V+F3wGLChldmJvSifkpJzCj1LySUDvlUITdauYsnxLf/sp1anq w7XVw75xOO/TXP9wZ6u0G8XjbinE07VAR1G40OG2fOO25+M0KE6eEfTQv0039KlH BOPxa2WMC6yas/0kl7Da105ZlvpSkRJartggA+aqjFHxfI/kye8dSkObuTptgYP0 99cAEmo2ZE0Ik9k1ZHHaS1ZMtl4X2mLbfJCSOq0lAd3PgXZ44OZdz4cZBlIw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1787757879; x=1787844279; bh=JdqlVpt7/pdzVutdn11mWFNzSbY/Ef8orM9 GHM96CA8=; b=VxNUTbFDXY/0sYK9MHVaCYx3aepHgIxHEK41WwQc34N6zB1jllk Y1TvlTZQsIIiBCeWkfWBe+yxTFgmjdlYHUh5XDztuiX/hf38/YPNqdtEkQZm77Xg YQNmNFcAeSschdJadBnVQstFP9klJsthpKR4RteY6C0r4Bc/DMxlRKI6irMhKRKG 1qH12t/c3VOtqGfF0Bkwdx/jixzbLGs9VzRIqOgiQNsJoQv955h1ZiXoafhAVPs3 d+59nWtZbsbafLm3T2j6YMe2SRzETQZ+5O1+yRenAWxkuQPqOQybJmZDdz0/NWLW aOEwgiBmPoYe8fH5PEtFbo/t8m1zM1GEo6A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTEInG3yPjlfGJOvKYO41PXxrKfBSTdxAYMb2kC97/570sWLYA7xRuZ5kVTZZqRZAd Sd0S7Xj+LzXqDnkCeGKEj7BqmWizxaK75RoxA+rA5ERYZlpZcPPurHae0rcvUXGGFcpnzj wcXSBVqTeofIpUESQ5n3xwfw2oBeNVeWOHkuZ1+QwIuY7ByLSr1Oep1svtSC0iGy4xbk1+ FxUT6gUL4Ys9xCYPzfJcg3U8YrXZUaZEbUM6e/WFyEOPfssgSVX+gHYB2MuJdbEWgPNuU3 46/aj467g7yg0ag5SExupJzh9Llnh1ScvloRJUJMeAprXG9X8N+PiXzUtpFCm/J4hxAXqE uYfLGiAP/k/8dW6lBFq9lHl7TdKlQTbP1I8S/dqnvSCyof8k2Cx/XuaeHxOrvarrwIJLAT fomc1SREhvOUGycy4bhDHboah8X5aJmVwrl7uwdNhGJYc2vmeO1hXlrVM+G0a4GXUm39lz BlC+VnmuyBoFoJF0V3wQzbjOiQX5Hvw4VPF/EczQXx+j8Ociu0SEnJY/ThEMIlItk40AiZ YrJuS6sI9MxDQ/Rh3YeUoZOBmHLKN3JvXIhHkwvk6P9KzVu9i6RnM0wHapn6tjXFl+YAEb NArcizPHmJ4CELa9Axi+y8ZXz0taWaBJxVjKDsSdBM1OQNsCxprtVeMijN9g X-ME-Proxy: Feedback-ID: if26b431b:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 26 Aug 2026 11:24:39 -0400 (EDT) From: Junio C Hamano To: "Yoichi NAKAYAMA via GitGitGadget" Cc: git@vger.kernel.org, Harald Nordgren , Yoichi Nakayama , "D. Ben Knoble" Subject: Re: [PATCH v9 1/4] checkout: extract function to display advice for ambiguous remotes In-Reply-To: (Yoichi NAKAYAMA via GitGitGadget's message of "Wed, 26 Aug 2026 10:45:07 +0000") References: Date: Wed, 26 Aug 2026 08:24:37 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain "Yoichi NAKAYAMA via GitGitGadget" writes: > From: Yoichi NAKAYAMA > > Signed-off-by: Yoichi NAKAYAMA Don't we want to describe a bit of explanation between these two lines? There are a few things that immediately come to mind as motivation for such changes, like that the original place was too deeply nested, that the original code was incorrectly indented, and that we are going to extend this function in later steps in the series. > +static void advice_disambiguating_remotes(enum checkout_command which_command) > +{ [2/4] updates this function to a better name; let's give it that name from the beginning.