* [PATCH v3] MyFirstContribution: add note on confirming patches
@ 2025-10-27 11:16 QueenJcloud
2025-10-27 15:09 ` Junio C Hamano
0 siblings, 1 reply; 7+ messages in thread
From: QueenJcloud @ 2025-10-27 11:16 UTC (permalink / raw)
To: git; +Cc: gitster, christian.couder, usmanakinyemi202, qjessa662
Add a note after the `git send-email` section explaining how
contributors can confirm that their patches reached the mailing
list by checking https://lore.kernel.org/git/. This helps
contributors verify that their emails were successfully delivered.
Signed-off-by: QueenJcloud <qjessa662@gmail.com>
---
Changes since v2:
- Distinctive/correct name to the email
- Added changelog note after '---'
- Removed extra blank line at the end of the section
- No other text or formatting changes
---
Documentation/MyFirstContribution.adoc | 6 ++-
...bution-add-note-on-confirming-patche.patch | 39 ++++++++++++++++
...bution-add-note-on-confirming-patche.patch | 46 +++++++++++++++++++
3 files changed, 90 insertions(+), 1 deletion(-)
create mode 100644 v2-0001-MyFirstContribution-add-note-on-confirming-patche.patch
create mode 100644 v3-0001-MyFirstContribution-add-note-on-confirming-patche.patch
diff --git a/Documentation/MyFirstContribution.adoc b/Documentation/MyFirstContribution.adoc
index 02ba8ba5f6..95f96b8451 100644
--- a/Documentation/MyFirstContribution.adoc
+++ b/Documentation/MyFirstContribution.adoc
@@ -1153,11 +1153,15 @@ NOTE: When you are sending a real patch, it will go to git@vger.kernel.org - but
please don't send your patchset from the tutorial to the real mailing list! For
now, you can send it to yourself, to make sure you understand how it will look.
+NOTE: After sending your patches, you can confirm that they reached the mailing
+list by visiting https://lore.kernel.org/git/. Use the search bar to find your
+name or the subject of your patch. If it appears, your email was successfully
+delivered.
+
After you run the command above, you will be presented with an interactive
prompt for each patch that's about to go out. This gives you one last chance to
edit or quit sending something (but again, don't edit code this way). Once you
press `y` or `a` at these prompts your emails will be sent! Congratulations!
-
Awesome, now the community will drop everything and review your changes. (Just
kidding - be patient!)
diff --git a/v2-0001-MyFirstContribution-add-note-on-confirming-patche.patch b/v2-0001-MyFirstContribution-add-note-on-confirming-patche.patch
new file mode 100644
index 0000000000..0e29510cba
--- /dev/null
+++ b/v2-0001-MyFirstContribution-add-note-on-confirming-patche.patch
@@ -0,0 +1,39 @@
+From b6e46728e3ce0714c03b9af548b734deadd95ca3 Mon Sep 17 00:00:00 2001
+From: QueenJcloud <qjessa662@gmail.com>
+Date: Fri, 24 Oct 2025 13:58:14 +0100
+Subject: [PATCH v2] MyFirstContribution: add note on confirming patches
+
+Add a note after the `git send-email` section explaining how
+contributors can confirm that their patches reached the mailing
+list by checking https://lore.kernel.org/git/.
+
+Signed-off-by: QueenJcloud <qjessa662@gmail.com>
+---
+ Documentation/MyFirstContribution.adoc | 6 ++++++
+ 1 file changed, 6 insertions(+)
+
+diff --git a/Documentation/MyFirstContribution.adoc b/Documentation/MyFirstContribution.adoc
+index 02ba8ba5f6..6e7f3036bb 100644
+--- a/Documentation/MyFirstContribution.adoc
++++ b/Documentation/MyFirstContribution.adoc
+@@ -1153,11 +1153,17 @@ NOTE: When you are sending a real patch, it will go to git@vger.kernel.org - but
+ please don't send your patchset from the tutorial to the real mailing list! For
+ now, you can send it to yourself, to make sure you understand how it will look.
+
++NOTE: After sending your patches, you can confirm that they reached the mailing
++list by visiting https://lore.kernel.org/git/. Use the search bar to find your
++name or the subject of your patch. If it appears, your email was successfully
++delivered.
++
+ After you run the command above, you will be presented with an interactive
+ prompt for each patch that's about to go out. This gives you one last chance to
+ edit or quit sending something (but again, don't edit code this way). Once you
+ press `y` or `a` at these prompts your emails will be sent! Congratulations!
+
++
+ Awesome, now the community will drop everything and review your changes. (Just
+ kidding - be patient!)
+
+--
+2.51.0.573.gb660e2dcb9
+
diff --git a/v3-0001-MyFirstContribution-add-note-on-confirming-patche.patch b/v3-0001-MyFirstContribution-add-note-on-confirming-patche.patch
new file mode 100644
index 0000000000..d5fe3e0bae
--- /dev/null
+++ b/v3-0001-MyFirstContribution-add-note-on-confirming-patche.patch
@@ -0,0 +1,46 @@
+From ad52256dcdfa5080dcba9451a67af1d3f89ba26d Mon Sep 17 00:00:00 2001
+From: QueenJcloud <qjessa662@gmail.com>
+Date: Fri, 24 Oct 2025 13:58:14 +0100
+Subject: [PATCH v3] MyFirstContribution: add note on confirming patches
+
+Add a note after the `git send-email` section explaining how
+contributors can confirm that their patches reached the mailing
+list by checking https://lore.kernel.org/git/. This helps
+contributors verify that their emails were successfully delivered.
+
+Signed-off-by: QueenJcloud <qjessa662@gmail.com>
+---
+Changes since v2:
+- Distinctive/correct name to the email
+- Added changelog note after '---'
+- Removed extra blank line at the end of the section
+- No other text or formatting changes
+---
+ Documentation/MyFirstContribution.adoc | 6 ++++++
+ 1 file changed, 6 insertions(+)
+
+diff --git a/Documentation/MyFirstContribution.adoc b/Documentation/MyFirstContribution.adoc
+index 02ba8ba5f6..6e7f3036bb 100644
+--- a/Documentation/MyFirstContribution.adoc
++++ b/Documentation/MyFirstContribution.adoc
+@@ -1153,11 +1153,17 @@ NOTE: When you are sending a real patch, it will go to git@vger.kernel.org - but
+ please don't send your patchset from the tutorial to the real mailing list! For
+ now, you can send it to yourself, to make sure you understand how it will look.
+
++NOTE: After sending your patches, you can confirm that they reached the mailing
++list by visiting https://lore.kernel.org/git/. Use the search bar to find your
++name or the subject of your patch. If it appears, your email was successfully
++delivered.
++
+ After you run the command above, you will be presented with an interactive
+ prompt for each patch that's about to go out. This gives you one last chance to
+ edit or quit sending something (but again, don't edit code this way). Once you
+ press `y` or `a` at these prompts your emails will be sent! Congratulations!
+
++
+ Awesome, now the community will drop everything and review your changes. (Just
+ kidding - be patient!)
+
+--
+2.51.0.573.gb660e2dcb9
+
--
2.51.0.573.gb660e2dcb9
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v3] MyFirstContribution: add note on confirming patches
2025-10-27 11:16 [PATCH v3] MyFirstContribution: add note on confirming patches QueenJcloud
@ 2025-10-27 15:09 ` Junio C Hamano
2025-10-27 15:50 ` Queen Jessa
0 siblings, 1 reply; 7+ messages in thread
From: Junio C Hamano @ 2025-10-27 15:09 UTC (permalink / raw)
To: QueenJcloud; +Cc: git, christian.couder, usmanakinyemi202
QueenJcloud <qjessa662@gmail.com> writes:
> Add a note after the `git send-email` section explaining how
> contributors can confirm that their patches reached the mailing
> list by checking https://lore.kernel.org/git/. This helps
> contributors verify that their emails were successfully delivered.
>
> Signed-off-by: QueenJcloud <qjessa662@gmail.com>
> ---
> Changes since v2:
> - Distinctive/correct name to the email
> - Added changelog note after '---'
> - Removed extra blank line at the end of the section
> - No other text or formatting changes
OK. It is a bit unexpected that you have picked a less name-looking
author identity (it is more common to use some form of your real
name around here, as described in Documentation/SubmittingPatches),
but that's OK.
> ---
> Documentation/MyFirstContribution.adoc | 6 ++-
> ...bution-add-note-on-confirming-patche.patch | 39 ++++++++++++++++
> ...bution-add-note-on-confirming-patche.patch | 46 +++++++++++++++++++
> 3 files changed, 90 insertions(+), 1 deletion(-)
> create mode 100644 v2-0001-MyFirstContribution-add-note-on-confirming-patche.patch
> create mode 100644 v3-0001-MyFirstContribution-add-note-on-confirming-patche.patch
You didn't mean to add these patch files, I strongly suspect ;-)
> diff --git a/Documentation/MyFirstContribution.adoc b/Documentation/MyFirstContribution.adoc
> index 02ba8ba5f6..95f96b8451 100644
> --- a/Documentation/MyFirstContribution.adoc
> +++ b/Documentation/MyFirstContribution.adoc
> @@ -1153,11 +1153,15 @@ NOTE: When you are sending a real patch, it will go to git@vger.kernel.org - but
> please don't send your patchset from the tutorial to the real mailing list! For
> now, you can send it to yourself, to make sure you understand how it will look.
>
> +NOTE: After sending your patches, you can confirm that they reached the mailing
> +list by visiting https://lore.kernel.org/git/. Use the search bar to find your
> +name or the subject of your patch. If it appears, your email was successfully
> +delivered.
> +
> After you run the command above, you will be presented with an interactive
> prompt for each patch that's about to go out. This gives you one last chance to
> edit or quit sending something (but again, don't edit code this way). Once you
> press `y` or `a` at these prompts your emails will be sent! Congratulations!
> -
> Awesome, now the community will drop everything and review your changes. (Just
> kidding - be patient!)
Will queue without these two extra files. Thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3] MyFirstContribution: add note on confirming patches
2025-10-27 15:09 ` Junio C Hamano
@ 2025-10-27 15:50 ` Queen Jessa
2025-10-27 16:05 ` Junio C Hamano
0 siblings, 1 reply; 7+ messages in thread
From: Queen Jessa @ 2025-10-27 15:50 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git, christian.couder, usmanakinyemi202
Thanks for reviewing and for the clarification. I appreciate the
feedback and will make sure to exclude generated patch files in future
submissions.
Regarding the author identity, I wanted to clarify that Queen Ediri
Jessa is my real name; the same one I used in my first patch. I
adjusted the configuration to ensure my author name matches the one in
the Signed-off-by line, based on your earlier feedback:
"We want to see that author identity and the identity on Sign-off
match. I can tweak the author identity on our end for this patch, but
if you are going to send further patches please make sure that your
[user] name = '...' configuration is what you wrote on the Sign-off
line."
Best regards,
Queen Ediri Jessa
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3] MyFirstContribution: add note on confirming patches
2025-10-27 15:50 ` Queen Jessa
@ 2025-10-27 16:05 ` Junio C Hamano
2025-10-27 16:11 ` Junio C Hamano
0 siblings, 1 reply; 7+ messages in thread
From: Junio C Hamano @ 2025-10-27 16:05 UTC (permalink / raw)
To: Queen Jessa; +Cc: git, christian.couder, usmanakinyemi202
Queen Jessa <qjessa662@gmail.com> writes:
> Thanks for reviewing and for the clarification. I appreciate the
> feedback and will make sure to exclude generated patch files in future
> submissions.
>
> Regarding the author identity, I wanted to clarify that Queen Ediri
> Jessa is my real name; the same one I used in my first patch. I
> adjusted the configuration to ensure my author name matches the one in
> the Signed-off-by line, based on your earlier feedback:
>
> "We want to see that author identity and the identity on Sign-off
> match. I can tweak the author identity on our end for this patch, but
> if you are going to send further patches please make sure that your
> [user] name = '...' configuration is what you wrote on the Sign-off
> line."
Now I am truly confused. The above reads to me that you prefer
"Queen Ediri Jessa" as your author identity, which was why I said I
was surprised because [v3] used QueenJcloud for author identity and
sign off (matching author identity to what was used to sign-off
feels like a tail wagging the dog).
I can make the author identity and sign-off of the version I queue
consistent locally before applying to save an extra patch exchange,
of course. But now I am not sure if I understand your preference
correctly.
Thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3] MyFirstContribution: add note on confirming patches
2025-10-27 16:05 ` Junio C Hamano
@ 2025-10-27 16:11 ` Junio C Hamano
2025-10-27 17:09 ` Queen Jessa
0 siblings, 1 reply; 7+ messages in thread
From: Junio C Hamano @ 2025-10-27 16:11 UTC (permalink / raw)
To: Queen Jessa; +Cc: git, christian.couder, usmanakinyemi202
Junio C Hamano <gitster@pobox.com> writes:
> I can make the author identity and sign-off of the version I queue
> consistent locally before applying to save an extra patch exchange,
> of course. But now I am not sure if I understand your preference
> correctly.
For now, I'll queue the following for this topic. Thanks!
----- >8 -----
From: Queen Ediri Jessa <qjessa662@gmail.com>
Date: Mon, 27 Oct 2025 12:16:00 +0100
Subject: [PATCH] MyFirstContribution: add note on confirming patches
Add a note after the `git send-email` section explaining how
contributors can confirm that their patches reached the mailing
list by checking https://lore.kernel.org/git/. This helps
contributors verify that their emails were successfully delivered.
Signed-off-by: Queen Ediri Jessa <qjessa662@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
Documentation/MyFirstContribution.adoc | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/MyFirstContribution.adoc b/Documentation/MyFirstContribution.adoc
index 02ba8ba5f6..f186dfbc89 100644
--- a/Documentation/MyFirstContribution.adoc
+++ b/Documentation/MyFirstContribution.adoc
@@ -1153,6 +1153,11 @@ NOTE: When you are sending a real patch, it will go to git@vger.kernel.org - but
please don't send your patchset from the tutorial to the real mailing list! For
now, you can send it to yourself, to make sure you understand how it will look.
+NOTE: After sending your patches, you can confirm that they reached the mailing
+list by visiting https://lore.kernel.org/git/. Use the search bar to find your
+name or the subject of your patch. If it appears, your email was successfully
+delivered.
+
After you run the command above, you will be presented with an interactive
prompt for each patch that's about to go out. This gives you one last chance to
edit or quit sending something (but again, don't edit code this way). Once you
--
2.51.2-678-g0cd646409c
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v3] MyFirstContribution: add note on confirming patches
2025-10-27 16:11 ` Junio C Hamano
@ 2025-10-27 17:09 ` Queen Jessa
2025-10-27 17:18 ` Junio C Hamano
0 siblings, 1 reply; 7+ messages in thread
From: Queen Jessa @ 2025-10-27 17:09 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git, christian.couder, usmanakinyemi202
okay. Thank you
On Mon, Oct 27, 2025 at 5:11 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Junio C Hamano <gitster@pobox.com> writes:
>
> > I can make the author identity and sign-off of the version I queue
> > consistent locally before applying to save an extra patch exchange,
> > of course. But now I am not sure if I understand your preference
> > correctly.
>
> For now, I'll queue the following for this topic. Thanks!
>
> ----- >8 -----
> From: Queen Ediri Jessa <qjessa662@gmail.com>
> Date: Mon, 27 Oct 2025 12:16:00 +0100
> Subject: [PATCH] MyFirstContribution: add note on confirming patches
>
> Add a note after the `git send-email` section explaining how
> contributors can confirm that their patches reached the mailing
> list by checking https://lore.kernel.org/git/. This helps
> contributors verify that their emails were successfully delivered.
>
> Signed-off-by: Queen Ediri Jessa <qjessa662@gmail.com>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
> Documentation/MyFirstContribution.adoc | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/MyFirstContribution.adoc b/Documentation/MyFirstContribution.adoc
> index 02ba8ba5f6..f186dfbc89 100644
> --- a/Documentation/MyFirstContribution.adoc
> +++ b/Documentation/MyFirstContribution.adoc
> @@ -1153,6 +1153,11 @@ NOTE: When you are sending a real patch, it will go to git@vger.kernel.org - but
> please don't send your patchset from the tutorial to the real mailing list! For
> now, you can send it to yourself, to make sure you understand how it will look.
>
> +NOTE: After sending your patches, you can confirm that they reached the mailing
> +list by visiting https://lore.kernel.org/git/. Use the search bar to find your
> +name or the subject of your patch. If it appears, your email was successfully
> +delivered.
> +
> After you run the command above, you will be presented with an interactive
> prompt for each patch that's about to go out. This gives you one last chance to
> edit or quit sending something (but again, don't edit code this way). Once you
> --
> 2.51.2-678-g0cd646409c
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3] MyFirstContribution: add note on confirming patches
2025-10-27 17:09 ` Queen Jessa
@ 2025-10-27 17:18 ` Junio C Hamano
0 siblings, 0 replies; 7+ messages in thread
From: Junio C Hamano @ 2025-10-27 17:18 UTC (permalink / raw)
To: Queen Jessa; +Cc: git, christian.couder, usmanakinyemi202
Queen Jessa <qjessa662@gmail.com> writes:
> okay. Thank you
>
Thank you for improving the documentation.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-10-27 17:18 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-27 11:16 [PATCH v3] MyFirstContribution: add note on confirming patches QueenJcloud
2025-10-27 15:09 ` Junio C Hamano
2025-10-27 15:50 ` Queen Jessa
2025-10-27 16:05 ` Junio C Hamano
2025-10-27 16:11 ` Junio C Hamano
2025-10-27 17:09 ` Queen Jessa
2025-10-27 17:18 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).