From: Junio C Hamano <gitster@pobox.com>
To: kristofferhaugsbakk@fastmail.com
Cc: git@vger.kernel.org, Kristoffer Haugsbakk <code@khaugsbakk.name>
Subject: Re: [PATCH] doc: patch-id: fix accidental literal blocks
Date: Sun, 28 Sep 2025 09:01:59 -0700 [thread overview]
Message-ID: <xmqq4ism7eh4.fsf@gitster.g> (raw)
In-Reply-To: <0520e8f9caf.1759067095.git.code@khaugsbakk.name> (kristofferhaugsbakk@fastmail.com's message of "Sun, 28 Sep 2025 16:03:08 +0200")
kristofferhaugsbakk@fastmail.com writes:
> From: Kristoffer Haugsbakk <code@khaugsbakk.name>
>
> The options here are apparently written with the assumption that you
> can continue a block like e.g. a description list by maintaining the
> same indentation level. This is not the the case; you need to use list
> continuation (+) for the elements following the first paragraph if you
> want to be guaranteed a predictable output
>
> This is kind of subtle since only the last paragraph of each option gets
> rendered in an unintended way, namely as literal blocks. This is easier
> to see in the HTML output since the man page output just has a slightly
> larger indentation on these paragraphs.
Hmph, I've always thought that the practice breaks every paragraph
except for the first one (which is the same as "only the last",
only when you have exactly 2 paragraphs; when you have more than 2,
it makes a difference).
The changes in the diff part all look reasonable to me.
Thanks.
next prev parent reply other threads:[~2025-09-28 16:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-28 14:03 [PATCH] doc: patch-id: fix accidental literal blocks kristofferhaugsbakk
2025-09-28 15:45 ` Kristoffer Haugsbakk
2025-09-28 16:01 ` Junio C Hamano [this message]
2025-09-28 19:25 ` Kristoffer Haugsbakk
2025-09-28 19:37 ` Junio C Hamano
2025-09-29 20:47 ` [PATCH v2] " kristofferhaugsbakk
2025-09-29 22:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4ism7eh4.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=code@khaugsbakk.name \
--cc=git@vger.kernel.org \
--cc=kristofferhaugsbakk@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).