From: Junio C Hamano <gitster@pobox.com>
To: Hosam Aly <hosamaly6@gmail.com>
Cc: "D. Ben Knoble" <ben.knoble@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: Bug report: Untracked file lost from git stash
Date: Thu, 25 Sep 2025 14:06:38 -0700 [thread overview]
Message-ID: <xmqq4isqfdi9.fsf@gitster.g> (raw)
In-Reply-To: <CAJA-u1oORK9b2=mg-s_n6-Jn3VBhe6sqrWg8VN0-MdEOjZGcwg@mail.gmail.com> (Hosam Aly's message of "Thu, 25 Sep 2025 23:22:40 +0300")
Hosam Aly <hosamaly6@gmail.com> writes:
> Feature request: I wish that the maintainers would consider changing
> the default value of `stash.showIncludeUntracked` to true. If
> something is stashed and the user asks about it, they should be told
> about it without hiding anything. Consider the case where all the
> stashed files are untracked; `git stash show` currently shows nothing,
> which is very confusing.
Do we include untracked paths in the stash by default without
configuration and/or command line option? If we do, then such a
change will affect so many folks that it would be possible to do so
only at a large version boundary, like Git 3.0.
But untracked paths are not recorded by default, and a stash entry
that records the untracked ones is a sign enough that the user cares
about these untracked ones when the stash entry was created.
Even though I do dislike any suggestion to change existing behaviour
established more than a few years, I would be more sympathetic than
usual to a wish for such a change in the default. In other words, I
tend to agree that the default should show untracked if recorded. I
am actually tempted to argue that the presence of the configuration
variable stash.showIncludeUntracked and the "--include-untracked"
command line option is a bug ;-) but I won't.
Thanks.
prev parent reply other threads:[~2025-09-25 21:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 15:29 Bug report: Untracked file lost from git stash Hosam Aly
2025-09-24 18:13 ` D. Ben Knoble
2025-09-25 20:22 ` Hosam Aly
2025-09-25 21:06 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4isqfdi9.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=ben.knoble@gmail.com \
--cc=git@vger.kernel.org \
--cc=hosamaly6@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).