From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Han Young <hanyang.tony@bytedance.com>, git@vger.kernel.org
Subject: Re: [PATCH] blame: remove parameter detailed in get_commit_info()
Date: Mon, 28 Jul 2025 08:40:25 -0700 [thread overview]
Message-ID: <xmqq4iuwxr12.fsf@gitster.g> (raw)
In-Reply-To: <aIcSYs7LxkJeRA-9@pks.im> (Patrick Steinhardt's message of "Mon, 28 Jul 2025 08:02:10 +0200")
Patrick Steinhardt <ps@pks.im> writes:
> On Mon, Jul 28, 2025 at 11:55:48AM +0800, Han Young wrote:
>> The get_commit_info() function accepts a parameter that can be used to
>> stop the commit parsing early.
>> However, none of the callers use this feature, and testing proved that
>> the performance gain of stopping parsing early is negligible.
Is it negligible but measurable, or negligible and unmeasurable?
> Funny enough it doesn't seem like the `detailed` field was ever used.
> `get_commit_info()` was introduced all the way back in cee7f245dca
> (git-pickaxe: blame rewritten., 2006-10-19), and even back then all
> callers passed `1` as the `detailed` parameter.
>
> So this patch looks obviously correct to me, thanks!
I am all for simplifying. It is great to see us lose more lines.
Thanks.
next prev parent reply other threads:[~2025-07-28 15:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-28 3:55 [PATCH] blame: remove parameter detailed in get_commit_info() Han Young
2025-07-28 6:02 ` Patrick Steinhardt
2025-07-28 15:40 ` Junio C Hamano [this message]
2025-07-29 2:50 ` [External] " Han Young
2025-07-29 5:02 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2025-07-28 3:25 Han Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4iuwxr12.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=hanyang.tony@bytedance.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).