From: Junio C Hamano <gitster@pobox.com>
To: Mark Mentovai <mark@chromium.org>
Cc: "Torsten Bögershausen" <tboegi@web.de>,
"Git Development" <git@vger.kernel.org>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Derrick Stolee" <stolee@gmail.com>
Subject: Re: [PATCH v2] t: run tests from a normalized working directory
Date: Tue, 03 Jun 2025 11:22:35 -0700 [thread overview]
Message-ID: <xmqq4iwwk7mc.fsf@gitster.g> (raw)
In-Reply-To: <08b9b990-9ddc-740e-99ab-82d09fb30ef3@chromium.org> (Mark Mentovai's message of "Tue, 3 Jun 2025 09:15:54 -0400 (EDT)")
Mark Mentovai <mark@chromium.org> writes:
> Torsten Bögershausen wrote:
>> On Mon, Jun 02, 2025 at 02:32:35PM -0700, Junio C Hamano wrote:
>>> ...
>>> Yes. You need to specify what you are canonicalizing to, and once
>>> you are going to do so, there is no need for that heavy verb, i.e.
>>> you do not need to say "canonicalize it to realpath"---you say "turn
>>> it into realpath" and you convey what you want to say just fine.
>>>
>> Re-reading the help for realpath() and pwd, would this makes sense:
>> t: run tests from an absolute pathname
> ...
> Making a path absolute is a different transformation than what is at
> issue here. You may have been misled by the fact that pwd -P and
> realpath both make paths absolute in addition to performing symbolic
> link resolution. The latter is what's operative here.
>
> As I've explained, the paths in question are already absolute in git's
> test suite today, even without the proposed change. It's not correct
> to summarize the change as making paths absolute, when that's neither
> changing nor the crux of the problem.
Absolutely ;-)
"normalized" does invite "normalize to what standard" question, but
as you mentioned in an earlier post, "realpath" is a bit dense for
those who don't read realpath(3) manual pages, and "symlink-resolved
file path" is quite mouthful even though it might be understandable.
Let me merge it down with the commit title as-is and then cook it in
'next' during the -rc period.
Thanks.
prev parent reply other threads:[~2025-06-03 18:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 19:37 [PATCH] t7900: use pwd -P in macOS maintenance test Mark Mentovai
2025-05-23 20:08 ` Eric Sunshine
2025-05-23 20:42 ` Junio C Hamano
2025-05-23 21:24 ` Eric Sunshine
2025-05-23 21:51 ` Junio C Hamano
2025-05-24 4:39 ` Mark Mentovai
2025-05-27 17:19 ` Junio C Hamano
2025-05-23 20:43 ` Mark Mentovai
2025-05-23 21:36 ` Eric Sunshine
2025-05-28 20:17 ` [PATCH v2] t: run tests from a normalized working directory Mark Mentovai
2025-05-28 23:08 ` Torsten Bögershausen
2025-05-30 5:04 ` Junio C Hamano
2025-05-31 5:46 ` Torsten Bögershausen
2025-06-01 16:38 ` Junio C Hamano
2025-06-02 16:08 ` Mark Mentovai
2025-06-02 21:32 ` Junio C Hamano
2025-06-03 5:02 ` Torsten Bögershausen
2025-06-03 13:15 ` Mark Mentovai
2025-06-03 18:22 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4iwwk7mc.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mark@chromium.org \
--cc=stolee@gmail.com \
--cc=sunshine@sunshineco.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).