git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: K Jayatheerth <jayatheerthkulkarni2005@gmail.com>
Cc: git@vger.kernel.org,  nasamuffin@google.com
Subject: Re: [PATCH v4 2/3] docs: clarify cmd_psuh signature and explain UNUSED macro
Date: Mon, 19 May 2025 10:55:47 -0700	[thread overview]
Message-ID: <xmqq4ixgo57g.fsf@gitster.g> (raw)
In-Reply-To: <20250518074317.73367-3-jayatheerthkulkarni2005@gmail.com> (K. Jayatheerth's message of "Sun, 18 May 2025 13:13:16 +0530")

K Jayatheerth <jayatheerthkulkarni2005@gmail.com> writes:

> diff --git a/Documentation/MyFirstContribution.adoc b/Documentation/MyFirstContribution.adoc
> index ef190d8748..da15d43d1f 100644
> --- a/Documentation/MyFirstContribution.adoc
> +++ b/Documentation/MyFirstContribution.adoc
> @@ -142,15 +142,31 @@ command in `builtin/psuh.c`. Create that file, and within it, write the entry
> ...
>  ----
> -int cmd_psuh(int argc, const char **argv, const char *prefix)
> +int cmd_psuh(int argc UNUSED, const char **argv UNUSED, 

I removed the new trailing whitespace on this line while queuing, so
no need to resend only to fix this.

Thanks.

  reply	other threads:[~2025-05-19 17:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-18  7:43 [PATCH v4 0/3] Update MyFirstContribution.adoc to follow modern practices K Jayatheerth
2025-05-18  7:43 ` [PATCH v4 1/3] docs: remove unused mentoring mailing list reference K Jayatheerth
2025-05-18  7:43 ` [PATCH v4 2/3] docs: clarify cmd_psuh signature and explain UNUSED macro K Jayatheerth
2025-05-19 17:55   ` Junio C Hamano [this message]
2025-05-18  7:43 ` [PATCH v4 3/3] docs: replace git_config to repo_config K Jayatheerth
2025-05-19 17:54 ` [PATCH v4 0/3] Update MyFirstContribution.adoc to follow modern practices Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq4ixgo57g.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jayatheerthkulkarni2005@gmail.com \
    --cc=nasamuffin@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).