git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: "Elijah Newren" <newren@gmail.com>,
	"David Aguilar" <davvid@gmail.com>,
	git@vger.kernel.org,
	"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH v2 3/3] difftool: eliminate use of USE_THE_REPOSITORY_VARIABLE
Date: Fri, 07 Feb 2025 09:49:14 -0800	[thread overview]
Message-ID: <xmqq4j15hch1.fsf@gitster.g> (raw)
In-Reply-To: <Z6WoEjEo9Seffm_q@pks.im> (Patrick Steinhardt's message of "Fri, 7 Feb 2025 07:28:34 +0100")

Patrick Steinhardt <ps@pks.im> writes:

> On Thu, Feb 06, 2025 at 12:31:14AM -0800, Elijah Newren wrote:
>> On Wed, Feb 5, 2025 at 8:20 PM David Aguilar <davvid@gmail.com> wrote:
>> ...
>> 
>> Nice; thanks for working on this.
>
> Yup, thanks for rerolling. This version is much easier to read indeed
> and looks good to me.

Thanks, all, for working on this and reviewing the patches.
Looking very good.

Let me mark the topic for 'next'.

  reply	other threads:[~2025-02-07 17:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-06  4:20 [PATCH v2 1/3] difftool: eliminate use of global variables David Aguilar
2025-02-06  4:20 ` [PATCH v2 2/3] difftool: eliminate use of the_repository David Aguilar
2025-02-06  8:30   ` Elijah Newren
2025-02-06  4:20 ` [PATCH v2 3/3] difftool: eliminate use of USE_THE_REPOSITORY_VARIABLE David Aguilar
2025-02-06  8:31   ` Elijah Newren
2025-02-07  6:28     ` Patrick Steinhardt
2025-02-07 17:49       ` Junio C Hamano [this message]
2025-02-06  8:29 ` [PATCH v2 1/3] difftool: eliminate use of global variables Elijah Newren
2025-02-07  4:44   ` David Aguilar
2025-02-06 13:34 ` Junio C Hamano
2025-02-06 18:08   ` Elijah Newren
2025-02-06 19:07     ` Junio C Hamano
2025-02-07  6:28     ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq4j15hch1.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=avarab@gmail.com \
    --cc=davvid@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=newren@gmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).