From: Junio C Hamano <gitster@pobox.com>
To: Mike Hommey <mh@glandium.org>
Cc: git@vger.kernel.org, peff@peff.net
Subject: Re: [PATCH] Fix unused-parameter warnings with NO_ICONV
Date: Wed, 02 Oct 2024 15:39:26 -0700 [thread overview]
Message-ID: <xmqq4j5uku3l.fsf@gitster.g> (raw)
In-Reply-To: <20241002200140.2123584-1-mh@glandium.org> (Mike Hommey's message of "Thu, 3 Oct 2024 05:01:40 +0900")
Mike Hommey <mh@glandium.org> writes:
> The jk/unused-parameters topic enabled -Wunused-parameter. Some code in
> some non-typical configuration lacked annotations.
>
> Signed-off-by: Mike Hommey <mh@glandium.org>
> ---
> utf8.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Thanks.
> diff --git a/utf8.h b/utf8.h
> index fcd5167baf..cce299d274 100644
> --- a/utf8.h
> +++ b/utf8.h
> @@ -33,8 +33,9 @@ char *reencode_string_len(const char *in, size_t insz,
> const char *in_encoding,
> size_t *outsz);
> #else
> -static inline char *reencode_string_len(const char *a, size_t b,
> - const char *c, const char *d, size_t *e)
> +static inline char *reencode_string_len(const char *a UNUSED, size_t b UNUSED,
> + const char *c UNUSED,
> + const char *d UNUSED, size_t *e)
> { if (e) *e = 0; return NULL; }
> #endif
prev parent reply other threads:[~2024-10-02 22:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 9:06 [PATCH] Fix unused-parameter warnings with NO_ICONV Mike Hommey
2024-10-02 9:47 ` Kristoffer Haugsbakk
2024-10-02 20:01 ` Mike Hommey
2024-10-02 22:01 ` Jeff King
2024-10-03 21:02 ` Mike Hommey
2024-10-02 22:39 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4j5uku3l.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mh@glandium.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).